Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752951AbdDNNoD (ORCPT ); Fri, 14 Apr 2017 09:44:03 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35676 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752812AbdDNNoB (ORCPT ); Fri, 14 Apr 2017 09:44:01 -0400 Date: Fri, 14 Apr 2017 21:43:37 +0800 From: Dong Aisheng To: Mark Brown Cc: Dong Aisheng , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] regulator: core: Only propagate voltage changes to if it can change voltages Message-ID: <20170414134336.GA25418@b29396-OptiPlex-7040> References: <20170413180316.617-1-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170413180316.617-1-broonie@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 584 Lines: 20 On Thu, Apr 13, 2017 at 07:03:15PM +0100, Mark Brown wrote: > When we are propagating voltage changes to parent regulators don't > bother if the parent does not have permission to change voltages. This > simplifies error checking in the function for cases where the regulator > lacks some of the voltage operations. > > Reported-by: Dong Aisheng > Signed-off-by: Mark Brown > --- > > Untested. > Thanks for the fix. Tested-by: Dong Aisheng Reviewed-by: Dong Aisheng Regards Dong Aisheng