Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754045AbdDNOVP (ORCPT ); Fri, 14 Apr 2017 10:21:15 -0400 Received: from smtp-in.kfki.hu ([148.6.0.26]:57345 "EHLO smtp1.kfki.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753309AbdDNOVN (ORCPT ); Fri, 14 Apr 2017 10:21:13 -0400 X-Greylist: delayed 327 seconds by postgrey-1.27 at vger.kernel.org; Fri, 14 Apr 2017 10:21:12 EDT Date: Fri, 14 Apr 2017 16:15:41 +0200 (CEST) From: Jozsef Kadlecsik To: Pablo Neira Ayuso cc: netdev@vger.kernel.org, Aaron Conole , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf-next] ipset: remove unused function __ip_set_get_netlink In-Reply-To: <20170413232842.GC7721@salvia> Message-ID: References: <20170410195237.19909-1-aconole@bytheb.org> <20170413232842.GC7721@salvia> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1820 Lines: 59 Hi Pablo, On Fri, 14 Apr 2017, Pablo Neira Ayuso wrote: > On Mon, Apr 10, 2017 at 03:52:37PM -0400, Aaron Conole wrote: > > There are no in-tree callers. > > @Jozsef, let me know if I should just take this to save you a pull > request. Just take it, thank you. Acked-by: Jozsef Kadlecsik Best regards, Jozsef > > Signed-off-by: Aaron Conole > > --- > > net/netfilter/ipset/ip_set_core.c | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c > > index c296f9b..68ba531 100644 > > --- a/net/netfilter/ipset/ip_set_core.c > > +++ b/net/netfilter/ipset/ip_set_core.c > > @@ -501,14 +501,6 @@ __ip_set_put(struct ip_set *set) > > * a separate reference counter > > */ > > static inline void > > -__ip_set_get_netlink(struct ip_set *set) > > -{ > > - write_lock_bh(&ip_set_ref_lock); > > - set->ref_netlink++; > > - write_unlock_bh(&ip_set_ref_lock); > > -} > > - > > -static inline void > > __ip_set_put_netlink(struct ip_set *set) > > { > > write_lock_bh(&ip_set_ref_lock); > > -- > > 2.9.3 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > - E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary