Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752137AbdDNQH2 (ORCPT ); Fri, 14 Apr 2017 12:07:28 -0400 Received: from mail-bn3nam01on0061.outbound.protection.outlook.com ([104.47.33.61]:59193 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751147AbdDNQHW (ORCPT ); Fri, 14 Apr 2017 12:07:22 -0400 From: "Kershner, David A" To: Logan Gunthorpe , Christoph Hellwig , "Martin K. Petersen" , Sagi Grimberg , Jens Axboe , Tejun Heo , Greg Kroah-Hartman , Dan Williams , Ross Zwisler , Matthew Wilcox , Sumit Semwal , Ming Lin , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" , "intel-gfx@lists.freedesktop.org" , "linux-raid@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-nvdimm@lists.01.org" , "linux-scsi@vger.kernel.org" , "fcoe-devel@open-fcoe.org" , "open-iscsi@googlegroups.com" , "megaraidlinux.pdl@broadcom.com" , *S-Par-Maintainer , "devel@driverdev.osuosl.org" , "target-devel@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "rds-devel@oss.oracle.com" CC: Steve Wise , Stephen Bates Subject: RE: [PATCH 10/22] staging: unisys: visorbus: Make use of the new sg_map helper function Thread-Topic: [PATCH 10/22] staging: unisys: visorbus: Make use of the new sg_map helper function Thread-Index: AQHStKI06Juseua4jEm39st3EnIMO6HFCKdw Date: Fri, 14 Apr 2017 16:07:14 +0000 Message-ID: References: <1492121135-4437-1-git-send-email-logang@deltatee.com> <1492121135-4437-11-git-send-email-logang@deltatee.com> In-Reply-To: <1492121135-4437-11-git-send-email-logang@deltatee.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: deltatee.com; dkim=none (message not signed) header.d=none;deltatee.com; dmarc=none action=none header.from=unisys.com; x-originating-ip: [108.36.162.151] x-microsoft-exchange-diagnostics: 1;CY4PR07MB3175;7:C9NgZbIJGjng9Kop6YoTilgwi7PQ6HhzRy3cs6m7Cd5DBcTLl61i2+MIe8XbHzzUE08fKo9EV9hg24U2GBEL23Wk4XsOcxZzX4AHRTmBwNY8kgOa8hH/s0dNRR6XB5jFXmaCoh1/z9K/Nrt0hTt0N6tLJDK0CZgUH+1eejZPzdjnrMyrpk/iq18hcLjw4FaD2vz8ntuhNdH0qngbIM0mDRQ3H0gmxmzdnWszCx7W7TUhO/KPEWQwvjMgm+i/sE/OxB/+w77E9blREjixU77SGFd//1ReRpw7GvF73HJjdYViwSY1i6j/SvK3Eofm5oVSQIfVAoshAJ0qBf4WKYsv2A== x-ms-office365-filtering-correlation-id: 96af7371-6464-4257-8ea7-08d48350510f x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075)(201703031133081);SRVR:CY4PR07MB3175; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(174360191007938); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(20161123560025)(6072148);SRVR:CY4PR07MB3175;BCL:0;PCL:0;RULEID:;SRVR:CY4PR07MB3175; x-forefront-prvs: 02778BF158 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39410400002)(39850400002)(39450400003)(39860400002)(39400400002)(13464003)(6506006)(5660300001)(50986999)(102836003)(3846002)(6116002)(54356999)(76176999)(229853002)(53936002)(3660700001)(8676002)(81166006)(2906002)(2201001)(8936002)(25786009)(86362001)(38730400002)(3280700002)(4326008)(2900100001)(7696004)(2561002)(305945005)(33656002)(122556002)(2950100002)(7416002)(66066001)(77096006)(2501003)(55016002)(74316002)(99286003)(8666007)(9686003)(54906002)(7736002)(6436002)(189998001)(6246003)(2421001)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR07MB3175;H:CY4PR07MB3176.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: unisys.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2017 16:07:14.5297 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8d894c2b-238f-490b-8dd1-d93898c5bf83 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3175 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v3EG7ii1006391 Content-Length: 1840 Lines: 61 > -----Original Message----- > From: Logan Gunthorpe [mailto:logang@deltatee.com] ... > Subject: [PATCH 10/22] staging: unisys: visorbus: Make use of the new > sg_map helper function > > Straightforward conversion to the new function. > > Signed-off-by: Logan Gunthorpe Can you add Acked-by for this patch? Acked-by: David Kershner Tested on s-Par and no problems. Thanks, David Kershner > --- > drivers/staging/unisys/visorhba/visorhba_main.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c > b/drivers/staging/unisys/visorhba/visorhba_main.c > index 0ce92c8..2d8c8bc 100644 > --- a/drivers/staging/unisys/visorhba/visorhba_main.c > +++ b/drivers/staging/unisys/visorhba/visorhba_main.c > @@ -842,7 +842,6 @@ do_scsi_nolinuxstat(struct uiscmdrsp *cmdrsp, struct > scsi_cmnd *scsicmd) > struct scatterlist *sg; > unsigned int i; > char *this_page; > - char *this_page_orig; > int bufind = 0; > struct visordisk_info *vdisk; > struct visorhba_devdata *devdata; > @@ -869,11 +868,14 @@ do_scsi_nolinuxstat(struct uiscmdrsp *cmdrsp, > struct scsi_cmnd *scsicmd) > > sg = scsi_sglist(scsicmd); > for (i = 0; i < scsi_sg_count(scsicmd); i++) { > - this_page_orig = kmap_atomic(sg_page(sg + i)); > - this_page = (void *)((unsigned long)this_page_orig | > - sg[i].offset); > + this_page = sg_map(sg + i, SG_KMAP_ATOMIC); > + if (IS_ERR(this_page)) { > + scsicmd->result = DID_ERROR << 16; > + return; > + } > + > memcpy(this_page, buf + bufind, sg[i].length); > - kunmap_atomic(this_page_orig); > + sg_unmap(sg + i, this_page, SG_KMAP_ATOMIC); > } > } else { > devdata = (struct visorhba_devdata *)scsidev->host- > >hostdata; > -- > 2.1.4