Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754199AbdDNRxY (ORCPT ); Fri, 14 Apr 2017 13:53:24 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:42806 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbdDNRxW (ORCPT ); Fri, 14 Apr 2017 13:53:22 -0400 Date: Fri, 14 Apr 2017 19:53:19 +0200 (CEST) From: Thomas Gleixner To: Christoph Hellwig cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] genirq: return the irq name from free_irq In-Reply-To: <20170414173649.GA26228@lst.de> Message-ID: References: <20170413070643.32165-1-hch@lst.de> <20170413070643.32165-3-hch@lst.de> <20170414173649.GA26228@lst.de> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 670 Lines: 24 On Fri, 14 Apr 2017, Christoph Hellwig wrote: > On Fri, Apr 14, 2017 at 07:28:42PM +0200, Thomas Gleixner wrote: > > On Thu, 13 Apr 2017, Christoph Hellwig wrote: > > > > > This allows callers to get back at them instead of having to store > > > it in another variable. > > > > Alternatively you tell the irq code to free it for you. Patch below. > > Yes, this should work to. But I think having the same layer free > something they allocated again is a tad cleaner in terms of layering. Fair enough. Was just a thought. Bjorn, please route it through PCI alltogether. For the whole series: Reviewed-by: Thomas Gleixner Thanks, tglx