Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754690AbdDNTKI (ORCPT ); Fri, 14 Apr 2017 15:10:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51198 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752086AbdDNTKG (ORCPT ); Fri, 14 Apr 2017 15:10:06 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 12AB860D60 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH V8 2/5] PCI/ASPM: split pci_aspm_init() into two To: Bjorn Helgaas , Rajat Jain References: <1491627351-1111-1-git-send-email-okaya@codeaurora.org> <1491627351-1111-3-git-send-email-okaya@codeaurora.org> Cc: "linux-pci@vger.kernel.org" , Timur Tabi , "Patel, Mayurkumar" , linux-arm-msm , linux-arm , Shawn Lin , Julia Lawall , David Daney , "linux-kernel@vger.kernel.org" , Rajat Jain From: Sinan Kaya Message-ID: <04c89a56-5e33-22e7-8665-cd94ac56d920@codeaurora.org> Date: Fri, 14 Apr 2017 15:10:02 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 625 Lines: 13 On 4/13/2017 2:25 PM, Bjorn Helgaas wrote: > I agree, and I made that change on my branch. I also renamed these to > pci_aspm_init_downstream_port() (for Root Ports and Switch Downstream > Ports) and pci_aspm_init_upstream_port() (for Switch Upstream Ports > and Endpoints) to try to match the terminology in the spec. OK. I reordered and renamed the functions according to your suggestions on my local copy too. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.