Date: Sat, 15 Apr 2017 00:26:05 +0200
From: Daniel Kiper <daniel.kiper@oracle.com>
To: Petr Tesarik <ptesarik@suse.com>
Cc: Juergen Gross <jgross@suse.com>, Daniel Kiper <dkiper@net-space.pl>,
        linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in
 paddr_vmcoreinfo_note()
Message-ID: <20170414222605.GA16658@olila.local.net-space.pl>
References: <20170331101438.28582-1-jgross@suse.com>
 <20170403124257.GA3439@router-fw-old.local.net-space.pl>
 <1df1de5c-8f89-3d65-b0cb-15a2a78992f8@suse.com>
 <20170411130058.GI4372@olila.local.net-space.pl>
 <20170411165916.698b6b85@hananiah.suse.cz>
 <20170411172008.GA16658@olila.local.net-space.pl>
 <20170414185336.673fa084@hananiah.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170414185336.673fa084@hananiah.suse.cz>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1593
Lines: 42

On Fri, Apr 14, 2017 at 06:53:36PM +0200, Petr Tesarik wrote:
> On Tue, 11 Apr 2017 19:20:08 +0200
> Daniel Kiper <daniel.kiper@oracle.com> wrote:
> > On Tue, Apr 11, 2017 at 04:59:16PM +0200, Petr Tesarik wrote:
> >[...]
> > > Tested-by: Petr Tesarik <ptesarik@suse.com>
> > >
> > > I copied the complete /proc/vmcore to a directory on disk. Exactly
> > > as expected, crash works both without the patch and with the patch, as
> > > it does not use VMCOREINFO at all (instead, crash obtains the
> > > information from kernel debuginfo directly).
> >
> > Thanks for doing the tests. I suppose that you have tested HVM guests.
>
> Not really. I crashed Dom0, which is in turn sent to the hypervisor, so
> the result is a complete host dump, including Xen hypervisor data and
> all domains.

OK.

> > IIRC, PV guests are not supported by crash right now due to p2m VMA
> > mapping. At least it was an issue some time ago. Is it still valid?
>
> Yes, this is correct. I tested this behaviour a few weeks ago.

Thanks for update.

> > Anyway, one guy in Oracle works on fix for that issue and I do review.
> > We are going to post it in 2-3 weeks.
>
> All right. FYI I do not plan to put much effort into it, as my focus has

OK.

> shifted towards libkdumpfile (https://github.com/ptesarik/libkdumpfile),
> and this library can open PV guest dump files without any issues.

Great! AIUI, it reminds my idea to make such think. However, I have not
have time to make it happen. Is it based on makedumpfile or written from
scratch? Do you plan support for Linux kernel dumps and/or Xen ones?

Daniel