Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755619AbdDNW7b convert rfc822-to-8bit (ORCPT ); Fri, 14 Apr 2017 18:59:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40060 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277AbdDNW72 (ORCPT ); Fri, 14 Apr 2017 18:59:28 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3DBE083F3F Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3DBE083F3F Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <149141141298.29162.5612793122429261720.stgit@warthog.procyon.org.uk> <149141145858.29162.13072730133817038218.stgit@warthog.procyon.org.uk> To: Thomas Gleixner Cc: dhowells@redhat.com, LKML , gnomes@lxorguk.ukuu.org.uk, gregkh@linuxfoundation.org, Daniel Lezcano , linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, Jens Rottmann , Andres Salomon Subject: Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/ MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <12227.1492210765.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Fri, 14 Apr 2017 23:59:25 +0100 Message-ID: <12228.1492210765@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 14 Apr 2017 22:59:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 605 Lines: 16 Thomas Gleixner wrote: > > -module_param_named(irq, timer_irq, int, 0644); > > +module_param_hw_named(irq, timer_irq, int, irq, 0644); > > MODULE_PARM_DESC(irq, "Which IRQ to use for the clock source MFGPT ticks."); > > I'm not sure about this. AFAIR the parameter is required to work on > anything else than some arbitrary hardware which has it mapped to 0. Should it then be set through in-kernel platform initialisation since the AMD Geode is an embedded chip? Btw, is it possible to use IRQ grants to prevent a device that has limited IRQ options from being drivable? David