DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3DBE083F3F
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <alpine.DEB.2.20.1704142021320.2327@nanos>
References: <alpine.DEB.2.20.1704142021320.2327@nanos> <149141141298.29162.5612793122429261720.stgit@warthog.procyon.org.uk> <149141145858.29162.13072730133817038218.stgit@warthog.procyon.org.uk>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: dhowells@redhat.com, LKML <linux-kernel@vger.kernel.org>,
        gnomes@lxorguk.ukuu.org.uk, gregkh@linuxfoundation.org,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
        Jens Rottmann <JRottmann@LiPPERTEmbedded.de>,
        Andres Salomon <dilinger@queued.net>
Subject: Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12227.1492210765.1@warthog.procyon.org.uk>
Content-Transfer-Encoding: 8BIT
Date: Fri, 14 Apr 2017 23:59:25 +0100
Message-ID: <12228.1492210765@warthog.procyon.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 605
Lines: 16

Thomas Gleixner <tglx@linutronix.de> wrote:

> > -module_param_named(irq, timer_irq, int, 0644);
> > +module_param_hw_named(irq, timer_irq, int, irq, 0644);
> >  MODULE_PARM_DESC(irq, "Which IRQ to use for the clock source MFGPT ticks.");
> 
> I'm not sure about this. AFAIR the parameter is required to work on
> anything else than some arbitrary hardware which has it mapped to 0.

Should it then be set through in-kernel platform initialisation since the
AMD Geode is an embedded chip?

Btw, is it possible to use IRQ grants to prevent a device that has limited IRQ
options from being drivable?

David