Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755605AbdDPJqw (ORCPT ); Sun, 16 Apr 2017 05:46:52 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:35678 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753848AbdDPJqt (ORCPT ); Sun, 16 Apr 2017 05:46:49 -0400 Date: Sun, 16 Apr 2017 11:46:43 +0200 From: Daniel Lezcano To: Nicolai Stange Cc: Michal Simek , John Stultz , linux-kernel@vger.kernel.org Subject: Re: [PATCH] microblaze/timer: set ->min_delta_ticks and ->max_delta_ticks Message-ID: <20170416094643.GU2078@mai> References: <20170326134403.16226-1-nicstange@gmail.com> <20170330194528.7047-1-nicstange@gmail.com> <20170407131429.GD2078@mai> <87h91pkr0w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87h91pkr0w.fsf@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1563 Lines: 41 On Sun, Apr 16, 2017 at 04:47:11AM +0200, Nicolai Stange wrote: > Hello Daniel, > > On Fri, Apr 07 2017, Daniel Lezcano wrote: > > > On Thu, Mar 30, 2017 at 09:45:28PM +0200, Nicolai Stange wrote: > >> diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c > >> index 999066192715..545ccd46edb3 100644 > >> --- a/arch/microblaze/kernel/timer.c > >> +++ b/arch/microblaze/kernel/timer.c > >> @@ -178,8 +178,10 @@ static __init int xilinx_clockevent_init(void) > >> clockevent_xilinx_timer.shift); > >> clockevent_xilinx_timer.max_delta_ns = > >> clockevent_delta2ns((u32)~0, &clockevent_xilinx_timer); > >> + clockevent_xilinx_timer.max_delta_ticks = (u32)~0; > > > > Can you take the opportunity to fix the type (unsigned long) ? > > Hmm, I personally think that it'd be better to leave the u32 there as it > corresponds to the hardware's counter width? > > clockevent_delta2ns()' latch argument has been of type unsigned long > from the beginning and this might indicate that at least this > driver's original author followed this line of reasoning... > > OTOH, I think that u32 is equivalent to unsigned long on microblaze, so > it doesn't matter much. > > Does the above convince you or do you still want the Yeah, I was nitpicking. Acked-by: Daniel Lezcano -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog