Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756156AbdDPPPs (ORCPT ); Sun, 16 Apr 2017 11:15:48 -0400 Received: from chaos.universe-factory.net ([37.72.148.22]:40096 "EHLO chaos.universe-factory.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755352AbdDPPPr (ORCPT ); Sun, 16 Apr 2017 11:15:47 -0400 Subject: Re: [PATCH net-next v2 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses To: Stephen Hemminger Cc: davem@davemloft.net, jbenc@redhat.com, hannes@stressinduktion.org, pshelar@ovn.org, aduyck@mirantis.com, roopa@cumulusnetworks.com, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org References: <95533e3ca4958ba2eca3efcc661713638feea220.1492187126.git.mschiffer@universe-factory.net> <20170414103830.111a24a8@xeon-e3> From: Matthias Schiffer Message-ID: <3c054ae3-ec68-ab20-0928-81e313a53cde@universe-factory.net> Date: Sun, 16 Apr 2017 17:15:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <20170414103830.111a24a8@xeon-e3> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JuXnqjarqDiS4BpaQrhbesiIPn8wECC0V" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3518 Lines: 87 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JuXnqjarqDiS4BpaQrhbesiIPn8wECC0V Content-Type: multipart/mixed; boundary="e9sgaWALmGCrRmhoEjqbHEULBeiMTohxm"; protected-headers="v1" From: Matthias Schiffer To: Stephen Hemminger Cc: davem@davemloft.net, jbenc@redhat.com, hannes@stressinduktion.org, pshelar@ovn.org, aduyck@mirantis.com, roopa@cumulusnetworks.com, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org Message-ID: <3c054ae3-ec68-ab20-0928-81e313a53cde@universe-factory.net> Subject: Re: [PATCH net-next v2 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses References: <95533e3ca4958ba2eca3efcc661713638feea220.1492187126.git.mschiffer@universe-factory.net> <20170414103830.111a24a8@xeon-e3> In-Reply-To: <20170414103830.111a24a8@xeon-e3> --e9sgaWALmGCrRmhoEjqbHEULBeiMTohxm Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 04/14/2017 07:38 PM, Stephen Hemminger wrote: > On Fri, 14 Apr 2017 18:44:46 +0200 > Matthias Schiffer wrote: >=20 >> As link-local addresses are only valid for a single interface, we can = allow >> to use the same VNI for multiple independent VXLANs, as long as the us= ed >> interfaces are distinct. This way, VXLANs can always be used as a drop= -in >> replacement for VLANs with greater ID space. >> >> This also extends VNI lookup to respect the ifindex when link-local IP= v6 >> addresses are used, so using the same VNI on multiple interfaces can >> actually work. >> >> Signed-off-by: Matthias Schiffer >=20 > Why does this have to be IPv6 specific? I'm not familar with IPv4 link-local addresses and how route lookup works= for them. vxlan_get_route() sets flowi4_oif to the outgoing interface; do= es __ip_route_output_key_hash() do the right thing for link-local addresses when such addresses are used on multiple interfaces? I see some special casing for multicast destinations, but none for link-local ones. >=20 > What about the case where VXLAN is not bound to an interface? > If that is used then that could be a problem. >=20 With patch 4/6, link-local IPv6 addresses can't be configured without an interface anymore. Matthias --e9sgaWALmGCrRmhoEjqbHEULBeiMTohxm-- --JuXnqjarqDiS4BpaQrhbesiIPn8wECC0V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEZmTnvaa2aYgexS51Fu8/ZMsgHZwFAljzip8ACgkQFu8/ZMsg HZy8QA/+M0kcHTZ30om072JNmdAiXUpIGu/itY2NwNpqlaKH3XhIlo3oBT6MJM1l TiPtjH3jz2uRQ6jU+cE1x3APk/seYnP8OgmTOq0XXhrLFu1L+Pzm9b4gjPpkKeuq Ll1zc4cw9Gc0uASw4aDyvzRggN1ZAwfxYf/GtQHfh2k4YPgS/YNSHNPQWTCuXNIu RX9oOCqIKMYTHa9jZzOuragwvM6ydz81STYCMOTZtH+Y46TGgJB60xBY45bxzjIm Y971WKhoDsBbiTspyWviOdd4p+OecGCMJ3vWzyw+roBkxyIsym7+UW6Q00Raw3Hj 9KErpmGOdzk9MzK2IqAwEdjApRj+ET8sfPsXGga7+5I6aqtEZfyy+Wdkw5tnfYZj 2Z/AjQsaPNi/mdESlXy6I03bcUGNo/gju27KGzNkr0yu3gLEaROiD+OrobkYunLV YurXODX7bALeYSy75TrzCyUtwJS3MxVUuKBWsO4QZsKl8Xc/IYRVYPdJgq8EkyKV QqDmxw04xNdceU2FnAzVjbF4H/llUrhSO18xTPtZkIaTcuVSgEXIDIubW0WnkBsn FBsph39HxG9VKZYpEnDNWsURuqOiMpeMQ5BYLmvgeZ8VTbUqc+bZtLQ0vRGwR3w0 CoUXAvtXW0rpWz19J22TFeo+IpbJUWTQgnOfpOcXSDIaHlek/nU= =dsL0 -----END PGP SIGNATURE----- --JuXnqjarqDiS4BpaQrhbesiIPn8wECC0V--