Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262379AbTFBOnD (ORCPT ); Mon, 2 Jun 2003 10:43:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262382AbTFBOnD (ORCPT ); Mon, 2 Jun 2003 10:43:03 -0400 Received: from meryl.it.uu.se ([130.238.12.42]:60325 "EHLO meryl.it.uu.se") by vger.kernel.org with ESMTP id S262379AbTFBOnB (ORCPT ); Mon, 2 Jun 2003 10:43:01 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16091.25998.133420.280664@gargle.gargle.HOWL> Date: Mon, 2 Jun 2003 16:56:14 +0200 From: mikpe@csd.uu.se To: Zwane Mwaikambo Cc: "Brian J. Murrell" , "" , "" Subject: Re: [PATCH][2.5] Honour dont_enable_local_apic flag In-Reply-To: References: <200306012308.h51N8K6j001404@harpo.it.uu.se> <1054511535.6676.85.camel@pc> X-Mailer: VM 6.90 under Emacs 20.7.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 36 Zwane Mwaikambo writes: > I agree with doing the clear apic capability flag, Brian how does this > fare? This patch alone should fix it. > > Index: linux-2.5/arch/i386/kernel/apic.c > =================================================================== > RCS file: /home/cvs/linux-2.5/arch/i386/kernel/apic.c,v > retrieving revision 1.54 > diff -u -p -B -r1.54 apic.c > --- linux-2.5/arch/i386/kernel/apic.c 31 May 2003 19:01:05 -0000 1.54 > +++ linux-2.5/arch/i386/kernel/apic.c 2 Jun 2003 03:50:31 -0000 > @@ -609,7 +609,7 @@ static int __init detect_init_APIC (void > > /* Disabled by DMI scan or kernel option? */ > if (dont_enable_local_apic) > - return -1; > + goto no_apic; > > /* Workaround for us being called before identify_cpu(). */ > get_cpu_vendor(&boot_cpu_data); > @@ -665,6 +665,7 @@ static int __init detect_init_APIC (void > return 0; > > no_apic: > + clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability); > printk("No local APIC present or hardware disabled\n"); > return -1; > } Looks good to me. Add a __setup to set dont_enable_local_apic and this should be sufficient for users of severely broken HW or emulations. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/