Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756834AbdDPUzf (ORCPT ); Sun, 16 Apr 2017 16:55:35 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:35455 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001AbdDPUzc (ORCPT ); Sun, 16 Apr 2017 16:55:32 -0400 MIME-Version: 1.0 In-Reply-To: <20170416103546.3021-1-contact@paulk.fr> References: <20170416103546.3021-1-contact@paulk.fr> From: Geert Uytterhoeven Date: Sun, 16 Apr 2017 22:55:30 +0200 X-Google-Sender-Auth: GFSiS8sxWoq63lnB-9b1zrp6PPM Message-ID: Subject: Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output To: Paul Kocialkowski Cc: "linux-kernel@vger.kernel.org" , Thierry Reding , Lee Jones , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , Linux PWM List , Linux Fbdev development list , linux-tegra@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 29 Hi Paul, On Sun, Apr 16, 2017 at 12:35 PM, Paul Kocialkowski wrote: > The move to a dedicated pwm_backlight_initial_power_state function in > commit 7613c922315e308a6486d802abed2eb74443dffd modified the condition > to set the enable gpio as output. This breaks specific use cases using > that GPIO, such as tegra124-based nyan Chromebooks where backlight > stopped working. > > This puts the condition back to the way it was before the move. > > Signed-off-by: Paul Kocialkowski Does "[PATCH v2] backlight: pwm_bl: Fix GPIO out for unimplemented .get_direction()" (https://lkml.org/lkml/2017/4/4/225) fix your issue? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds