Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932629AbdDQDqi (ORCPT ); Sun, 16 Apr 2017 23:46:38 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55174 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932455AbdDQDqg (ORCPT ); Sun, 16 Apr 2017 23:46:36 -0400 Subject: Re: [PATCH v3 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src To: Peter Zijlstra References: <1491875470-17904-1-git-send-email-maddy@linux.vnet.ibm.com> <1491875470-17904-2-git-send-email-maddy@linux.vnet.ibm.com> <20170413123849.556kqah6o6tzzs5d@hirez.programming.kicks-ass.net> Cc: mpe@ellerman.id.au, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org, paulus@samba.org, sukadev@linux.vnet.ibm.com, andrew.donnellan@au1.ibm.com, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, ast@kernel.org, eranian@google.com From: Madhavan Srinivasan Date: Mon, 17 Apr 2017 09:16:26 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170413123849.556kqah6o6tzzs5d@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17041703-0020-0000-0000-000000E761B4 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17041703-0021-0000-0000-000002A70B0F Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-17_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704170033 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2166 Lines: 62 On Thursday 13 April 2017 06:08 PM, Peter Zijlstra wrote: > On Tue, Apr 11, 2017 at 07:21:05AM +0530, Madhavan Srinivasan wrote: >> From: Sukadev Bhattiprolu >> >> perf_mem_data_src is an union that is initialized via the ->val field >> and accessed via the bitmap fields. For this to work on big endian >> platforms (Which is broken now), we also need a big-endian represenation >> of perf_mem_data_src. i.e, in a big endian system, if user request >> PERF_SAMPLE_DATA_SRC (perf report -d), will get the default value from >> perf_sample_data_init(), which is PERF_MEM_NA. Value for PERF_MEM_NA >> is constructed using shifts: >> >> /* TLB access */ >> #define PERF_MEM_TLB_NA 0x01 /* not available */ >> ... >> #define PERF_MEM_TLB_SHIFT 26 >> >> #define PERF_MEM_S(a, s) \ >> (((__u64)PERF_MEM_##a##_##s) << PERF_MEM_##a##_SHIFT) >> >> #define PERF_MEM_NA (PERF_MEM_S(OP, NA) |\ >> PERF_MEM_S(LVL, NA) |\ >> PERF_MEM_S(SNOOP, NA) |\ >> PERF_MEM_S(LOCK, NA) |\ >> PERF_MEM_S(TLB, NA)) >> >> Which works out as: >> >> ((0x01 << 0) | (0x01 << 5) | (0x01 << 19) | (0x01 << 24) | (0x01 << 26)) >> >> Which means the PERF_MEM_NA value comes out of the kernel as 0x5080021 >> in CPU endian. >> >> But then in the perf tool, the code uses the bitfields to inspect the >> value, and currently the bitfields are defined using little endian >> ordering. >> >> So eg. in perf_mem__tlb_scnprintf() we see: >> data_src->val = 0x5080021 >> op = 0x0 >> lvl = 0x0 >> snoop = 0x0 >> lock = 0x0 >> dtlb = 0x0 >> rsvd = 0x5080021 >> >> Patch does a minimal fix of adding big endian definition of the bitfields >> to match the values that are already exported by the kernel on big endian. >> And it makes no change on little endian. > I think it is important to note that there are no current big-endian > users. So 'fixing' this will not break anybody and will ensure future > users (next patch) will work correctly. > > Aside from that amendment, > > Acked-by: Peter Zijlstra (Intel) Thanks Maddy