Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932924AbdDQHER (ORCPT ); Mon, 17 Apr 2017 03:04:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45762 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932744AbdDQHEN (ORCPT ); Mon, 17 Apr 2017 03:04:13 -0400 Date: Mon, 17 Apr 2017 09:04:03 +0200 From: Greg KH To: Karim Eshapa Cc: jason@lakedaemon.ne, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging:skein: skein_base.h, skein_block.h: move macros into appropriate header files Message-ID: <20170417070403.GA23282@kroah.com> References: <1492390054-16925-1-git-send-email-karim.eshapa@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492390054-16925-1-git-send-email-karim.eshapa@gmail.com> User-Agent: Mutt/1.8.1 (2017-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 566 Lines: 19 On Mon, Apr 17, 2017 at 02:47:34AM +0200, Karim Eshapa wrote: > Macros more related to BLK operations. That doesn't make any sense to me, can you be more explicit? > Signed-off-by: Karim Eshapa > --- > drivers/staging/skein/skein_base.h | 28 ---------------------------- > drivers/staging/skein/skein_block.h | 28 ++++++++++++++++++++++++++++ > 2 files changed, 28 insertions(+), 28 deletions(-) Moving stuff from one file to another doesn't seem like it is really worth it. And where is patch 1/2 in this series? thanks, greg k-h