Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932871AbdDQI0D (ORCPT ); Mon, 17 Apr 2017 04:26:03 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:38764 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932524AbdDQI0A (ORCPT ); Mon, 17 Apr 2017 04:26:00 -0400 MIME-Version: 1.0 In-Reply-To: <60eb8e84-7914-4e25-4822-7e1d8fd8afcb@users.sourceforge.net> References: <60eb8e84-7914-4e25-4822-7e1d8fd8afcb@users.sourceforge.net> From: Gary Bisson Date: Mon, 17 Apr 2017 10:25:58 +0200 Message-ID: Subject: Re: pinctrl: imx: Checking reuse of grouping functionality To: SF Markus Elfring Cc: linux-gpio@vger.kernel.org, Alexander Shiyan , Fabio Estevam , Linus Walleij , Paul Gortmaker , Peng Fan , Tony Lindgren , Vladimir Zapolskiy , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v3H8QC9h001184 Content-Length: 1132 Lines: 29 Hi Markus, All, On Sat, Apr 15, 2017 at 9:55 PM, SF Markus Elfring wrote: > Hello, > > A preprocessor symbol like “CONFIG_GENERIC_PINCTRL_GROUPS” was introduced > by the commit c033a718f615b6b3ddc83ce3e0a217c30bd09cb5 (“pinctrl: stricten up > generic group code”) on 2017-01-03. Some functions are only available then > when this macro is defined. Yes because the pinctrl driver can be used without this configuration by some drivers. > I have got the impression that the corresponding programming interface is used > by the source file “drivers/pinctrl/freescale/pinctrl-imx.c” unconditionally. > How do you think about to extend specifications for conditional compilation there? However the imx pinctrl driver _absolutely_ needs this configuration to work. That is why it is selected automatically when the driver is enabled [1]. Therefore it isn't possible to build the driver without GENERIC_PINCTRL_GROUPS and so adding conditions is not necessary. Regards, Gary [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pinctrl/freescale/Kconfig#n3