From: Karim Eshapa <karim.eshapa@gmail.com>
To: gregkh@linuxfoundation.org
Cc: jason@lakedaemon.net, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, Karim Eshapa <karim.eshapa@gmail.com>
Subject: Re:staging:skein: skein_base.h, skein_block.h: move macros into appropriate header files
Date: Mon, 17 Apr 2017 17:04:28 +0200
Message-Id: <1492441468-4957-1-git-send-email-karim.eshapa@gmail.com>
In-Reply-To: <20170417070403.GA23282@kroah.com>
References: <20170417070403.GA23282@kroah.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1109
Lines: 29

On Mon, 17 Apr 2017 09:04:03 +0200, Greg KH wrote:
> On Mon, Apr 17, 2017 at 02:47:34AM +0200, Karim Eshapa wrote:
>>
>> Macros more related to BLK operations. 
>
> That doesn't make any sense to me, can you be more explicit?.

skein_block.h contains all fn's related to processing on 
different block size so , it's more finer to contain macros
that define block configuration, message,.. specially they
aren't even referenced in all files that include skein_base.h
but these macros I think still exist in driver files for future work as well.

> Moving stuff from one file to another doesn't seem like it is really
> worth it.
> And where is patch 1/2 in this series?

And, Moving stuff is what "TODO" see it is worth.
There is no patch1/2 sorry, but may be because I sent
the patch twice as one of the mails was witten wrong.

>> Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
>> ---
>> drivers/staging/skein/skein_base.h  | 28 ----------------------------
>> drivers/staging/skein/skein_block.h | 28 ++++++++++++++++++++++++++++
>>  2 files changed, 28 insertions(+), 28 deletions(-)

Thanks,
Karim