Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756701AbdDQPjS (ORCPT ); Mon, 17 Apr 2017 11:39:18 -0400 Received: from gagarine.paulk.fr ([109.190.93.129]:49798 "EHLO gagarine.paulk.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753734AbdDQPjQ (ORCPT ); Mon, 17 Apr 2017 11:39:16 -0400 Message-ID: <1492443526.12267.4.camel@paulk.fr> Subject: Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output From: Paul Kocialkowski To: Geert Uytterhoeven Cc: "linux-kernel@vger.kernel.org" , Thierry Reding , Lee Jones , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , Linux PWM List , Linux Fbdev development list , linux-tegra@vger.kernel.org Date: Mon, 17 Apr 2017 17:38:46 +0200 In-Reply-To: References: <20170416103546.3021-1-contact@paulk.fr> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-CtD7ssR0i9DXtq8WomxN" X-Mailer: Evolution 3.22.6 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2324 Lines: 61 --=-CtD7ssR0i9DXtq8WomxN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Le dimanche 16 avril 2017 =C3=A0 22:55 +0200, Geert Uytterhoeven a =C3=A9cr= it=C2=A0: > On Sun, Apr 16, 2017 at 12:35 PM, Paul Kocialkowski wr= ote: > > The move to a dedicated pwm_backlight_initial_power_state function in > > commit 7613c922315e308a6486d802abed2eb74443dffd modified the condition > > to set the enable gpio as output. This breaks specific use cases using > > that GPIO, such as tegra124-based nyan Chromebooks where backlight > > stopped working. > >=20 > > This puts the condition back to the way it was before the move. > >=20 > > Signed-off-by: Paul Kocialkowski >=20 > Does "[PATCH v2] backlight: pwm_bl: Fix GPIO out for unimplemented > .get_direction()" > (https://lkml.org/lkml/2017/4/4/225) fix your issue? This definitely solves the issue! Since this fixes broken backlight (that, in turn, makes systems unusable), perhaps this should be included in the next rc cycle? Cheers! --=20 Paul Kocialkowski, developer of free digital technology at the lower levels Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/ --=-CtD7ssR0i9DXtq8WomxN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEAbcMXZQMtj1fphLChP3B6o/ulQwFAlj04YYACgkQhP3B6o/u lQwn7Q/+N9vmCWl3gxixdLDLxRguK49d2NsspLp+j+0hr9P3ZyABbgNRQEobu4iX co+eb67SKgcIryEjuikKstTruHv291N6HtlZ9eQnmFjfKMbDFseIfBq9RQ1vRX3/ X1rKeifqfRBrDYR+PS16HtWv446stXe4Ta8yTJ0pR1n+h00SjhWxNIEJmUda/lZ0 n7ccxKVFvEGFxGLfj1GXDNP80N9Rb8OlDX1nWfgMuMWMKU1beMjmocLfGqXoMy4k fr+5CpZhPGwvjMc/7C4dGRCgUwbRkfwKFHxsHMuy5Yf/r7u4kA4pVLNa3bnpPleL tvExZ8nBdL5MnbuwBuSKEHYugq3kBR+qgG1xRL6trCNUGpMkpVTYtBQYei6fBOdX i5piOkbVb9Q0ymcNjgwa6YOJUI5a4BEf+3siSNSu6L4aP55QENMzoxoWCJjmOSfE VNK+zHrDgqf6ofkk0FWysDjt48Izbn/SfksPgDEFe5xDYkV5lmtvd5eCx7ZVVIiw SepdqDrzupvQMMfN/x8+Rc8fypCCQGR9tSe2p+DgIqKzUJaJJ+NIFTXFli6Gkct2 xV80M61B+Zkw2lqCfn+3WABoblQPKLDeeNWDbV2cktj5/o9BBnLSypputR8NTibm BpQXeCkeYtk2MAuniNYUwwl7xRceSUQgjZeMnCtQUYISKCxby9g= =yHIX -----END PGP SIGNATURE----- --=-CtD7ssR0i9DXtq8WomxN--