Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756730AbdDQPyw (ORCPT ); Mon, 17 Apr 2017 11:54:52 -0400 Received: from b.ns.miles-group.at ([95.130.255.144]:44724 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751874AbdDQPyu (ORCPT ); Mon, 17 Apr 2017 11:54:50 -0400 Subject: Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() To: Ralph Sennhauser , Amir Goldstein References: <1490864181-2192-1-git-send-email-richard@nod.at> <4c7a176b-6132-7936-a04f-d4def5e56320@nod.at> <646ae733-5037-3072-7151-b055a8fa1521@intel.com> <92bbb4d1-afe7-14f2-763b-051c7b12ff9e@nod.at> <2a2eebef-ed37-7829-b08f-482039306a6e@nod.at> <20170417172738.199803f5@gmail.com> Cc: Adrian Hunter , linux-mtd@lists.infradead.org, linux-kernel , Artem Bityutskiy , "stable [v4.9]" From: Richard Weinberger Message-ID: <3155babe-e3ed-b4bd-dc02-60d4c23e820d@nod.at> Date: Mon, 17 Apr 2017 17:54:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170417172738.199803f5@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 692 Lines: 17 Am 17.04.2017 um 17:27 schrieb Ralph Sennhauser: > Hi Amir, Richard > > Looks like the fix didn't make it into 4.11-rc7 either, isn't it time > to just disable O_TMPFILE support in ubifs for now? Giving plenty > time for the proper fix. As I said to Amir, don't panic. I'm *very* busy right now with non-computer stuff. My first fix is correct, I was wrong about the testing, it does the right thing, although it was not so clear. Except that my fix misses one error case which I wanted to push tomorrow since today is a official holiday here in Austria. For the next merge window I have a better approach which is better than (ab)using ubifs_jnl_update() for O_TMPFILE. Thanks, //richard