Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754732AbdDQQIq (ORCPT ); Mon, 17 Apr 2017 12:08:46 -0400 Received: from mout.web.de ([212.227.17.12]:62775 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752223AbdDQQIo (ORCPT ); Mon, 17 Apr 2017 12:08:44 -0400 Subject: Re: pinctrl: imx: Checking reuse of grouping functionality To: Gary Bisson Cc: linux-gpio@vger.kernel.org, Alexander Shiyan , Fabio Estevam , Linus Walleij , Paul Gortmaker , Peng Fan , Tony Lindgren , Vladimir Zapolskiy , LKML , kernel-janitors@vger.kernel.org References: <60eb8e84-7914-4e25-4822-7e1d8fd8afcb@users.sourceforge.net> From: SF Markus Elfring Message-ID: <2c82f25b-4095-fbb0-f766-c83387b46ef5@users.sourceforge.net> Date: Mon, 17 Apr 2017 18:08:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:txsEcEC6BqIcVnPG70UaoE/6LNOxvcN0T/HgWEkcVJsn6mlde03 W+OkeoWpsAZxzd7tDgE4KTb87uQyvl4jYEqKcaTbWTqlU0wurwL9PbVP0fm6nPVp2bczBnQ SGhYUcEHEorGWMbezvnQXblQFmzSkGSJsBY/aBIJ0fGSUdi4OGofY7P4kX08RgYVVk7XdV9 ILFVJeV6OTyTAi8/Egl4g== X-UI-Out-Filterresults: notjunk:1;V01:K0:/20/OxIHAe8=:t9pFFca3QLAs3joVOnOM7/ 9lHgJfaBCjA3xJz/FvywbxdcMD+zoaKniyoMQDi/O1sDJ2HVEHlpk8oCyXn/FxP7uINFmDnsQ wVlPRaTvwbgYi+i19bU2MYdCTTW5eO2cxNi9+CZ0bpSdnW48IxHRnFv8mp2beh5SHdhr86Or5 8WusdbVbZqTdNzR2FGiwKvfRWHtYTrHsgw6WmIfuv1gfttgb/MPwG/N0h4l7zMSvB3AFJLaDI efrF7ubKkCwBA2ZWNVRAXWfkm2YFrMAB8KTkUz/Irz/VYj0tUpnKKIAvngQMBAWnka48tNwAb hnmOsSa2YWc3cGIuMXRfUixRSmtqvoGk59BEpdxblanzWBgi8Mpm/iTa/YNMJMZFhFncO6eb2 vXk5anucK+O6/X8IBiMLa1eETCb2VTtD5jgxktIFxpubQ0KFrhssabUw0JZ96ePGbixnEESCA /IqSHq+eKu5Pm2TkyRtDoJOsabbjunZMkIMwKo3WSrmfeIhTT6Yxk5oRQRETd60O3o9xwiP2b +0G/kzqaPVwCVSeVqQxGqcfPyKgtxmZkN2aY/3HDsPxfho4urpNUuz6q35SuNVyvUtKsvXUOp CM0aT1nNt+YYjntGag0lDr1zFlwuSSkQUGwic94wTWV5ZahipdMNChJlRtB/v4bjzConvjFAP JELWeWxuOnDvVqY2wZ5R9BpQbUDyo3BKtB7Qd6Hkdit2hDbqrXCMfVIfdPB1tepYTuPYo4Rk6 EXeLQ/FWkR9T20MvKvdnoItHLGfmKNzTBVapFR/WksWWObiiBc2oWp8b+TB09KrPUpojtjZM2 5MEHdti Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 507 Lines: 12 > However the imx pinctrl driver _absolutely_ needs this configuration to work. Thanks for your explanation that the file “drivers/pinctrl/freescale/Kconfig” will usually provide needed information for this software module. Would it make sense to document such a requirement also by a preprocessor error directive in the source file “drivers/pinctrl/freescale/pinctrl-imx.c” for the special case if the macro “CONFIG_GENERIC_PINCTRL_GROUPS” would accidentally not be defined? Regards, Markus