Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754149AbdDQRSy (ORCPT ); Mon, 17 Apr 2017 13:18:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40150 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752528AbdDQRSt (ORCPT ); Mon, 17 Apr 2017 13:18:49 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CE67F60F32 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH v3 1/8] trace: ras: add ARM processor error information trace event To: Xie XiuQi , christoffer.dall@linaro.org, marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, james.morse@arm.com, fu.wei@linaro.org, rostedt@goodmis.org, hanjun.guo@linaro.org, shiju.jose@huawei.com Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, gengdongjiu@huawei.com, zhengqiang10@huawei.com, wuquanming@huawei.com, wangxiongfeng2@huawei.com References: <1490869877-118713-1-git-send-email-xiexiuqi@huawei.com> <1490869877-118713-11-git-send-email-xiexiuqi@huawei.com> <32ca4e7e-eb5e-a4ff-33d6-68d06e9242fb@codeaurora.org> <6c0d2652-71ba-aefc-d6cd-5cc9a0b0d729@huawei.com> <8aa30f6a-d18d-1cce-57dc-08efb52d822e@huawei.com> From: "Baicar, Tyler" Message-ID: Date: Mon, 17 Apr 2017 11:18:43 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <8aa30f6a-d18d-1cce-57dc-08efb52d822e@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5163 Lines: 118 On 4/16/2017 9:16 PM, Xie XiuQi wrote: > On 2017/4/17 11:08, Xie XiuQi wrote: >>> On 3/30/2017 4:31 AM, Xie XiuQi wrote: >>>> Add a new trace event for ARM processor error information, so that >>>> the user will know what error occurred. With this information the >>>> user may take appropriate action. >>>> >>>> These trace events are consistent with the ARM processor error >>>> information table which defined in UEFI 2.6 spec section N.2.4.4.1. >>>> >>>> --- >>>> v2: add trace enabled condition as Steven's suggestion. >>>> fix a typo. >>>> --- >>>> >>>> Cc: Steven Rostedt >>>> Cc: Tyler Baicar >>>> Signed-off-by: Xie XiuQi >>>> --- >>> ... >>>> +/* >>>> + * First define the enums in MM_ACTION_RESULT to be exported to userspace >>>> + * via TRACE_DEFINE_ENUM(). >>>> + */ >>>> +#undef EM >>>> +#undef EMe >>>> +#define EM(a, b) TRACE_DEFINE_ENUM(a); >>>> +#define EMe(a, b) TRACE_DEFINE_ENUM(a); >>>> + >>>> +ARM_PROC_ERR_TYPE >>>> +ARM_PROC_ERR_FLAGS >>> Are the above two lines supposed to be here? >>>> + >>>> +/* >>>> + * Now redefine the EM() and EMe() macros to map the enums to the strings >>>> + * that will be printed in the output. >>>> + */ >>>> +#undef EM >>>> +#undef EMe >>>> +#define EM(a, b) { a, b }, >>>> +#define EMe(a, b) { a, b } >>>> + >>>> +TRACE_EVENT(arm_proc_err, >>> I think it would be better to keep this similar to the naming of the current RAS trace events (right now we have mc_event, arm_event, aer_event, etc.). I would suggest using "arm_err_info_event" since this is handling the error information structures of the arm errors. >>>> + >>>> + TP_PROTO(const struct cper_arm_err_info *err), >>>> + >>>> + TP_ARGS(err), >>>> + >>>> + TP_STRUCT__entry( >>>> + __field(u8, type) >>>> + __field(u16, multiple_error) >>>> + __field(u8, flags) >>>> + __field(u64, error_info) >>>> + __field(u64, virt_fault_addr) >>>> + __field(u64, physical_fault_addr) >>> Validation bits should also be a part of this structure that way user space tools will know which of these fields are valid. >> Could we use the default value to check the validation which we have checked in TP_fast_assign? Yes, true...I guess we really don't need the validation bits then. >>>> + ), >>>> + >>>> + TP_fast_assign( >>>> + __entry->type = err->type; >>>> + >>>> + if (err->validation_bits & CPER_ARM_INFO_VALID_MULTI_ERR) >>>> + __entry->multiple_error = err->multiple_error; >>>> + else >>>> + __entry->multiple_error = ~0; >>>> + >>>> + if (err->validation_bits & CPER_ARM_INFO_VALID_FLAGS) >>>> + __entry->flags = err->flags; >>>> + else >>>> + __entry->flags = ~0; >>>> + >>>> + if (err->validation_bits & CPER_ARM_INFO_VALID_ERR_INFO) >>>> + __entry->error_info = err->error_info; >>>> + else >>>> + __entry->error_info = 0ULL; >>>> + >>>> + if (err->validation_bits & CPER_ARM_INFO_VALID_VIRT_ADDR) >>>> + __entry->virt_fault_addr = err->virt_fault_addr; >>>> + else >>>> + __entry->virt_fault_addr = 0ULL; >>>> + >>>> + if (err->validation_bits & CPER_ARM_INFO_VALID_PHYSICAL_ADDR) >>>> + __entry->physical_fault_addr = err->physical_fault_addr; >>>> + else >>>> + __entry->physical_fault_addr = 0ULL; >>>> + ), >>>> + >>>> + TP_printk("ARM Processor Error: type %s; count: %u; flags: %s;" >>> I think the "ARM Processor Error:" part of this should just be removed. Here's the output with this removed and the trace event renamed to arm_err_info_event. I think this looks much cleaner and matches the style used with the arm_event. >>> >>> -0 [020] .ns. 366.592434: arm_event: affinity level: 2; MPIDR: 0000000000000000; MIDR: 00000000510f8000; running state: 1; PSCI state: 0 >>> -0 [020] .ns. 366.592437: arm_err_info_event: type cache error; count: 0; flags: 0x3; error info: 0000000000c20058; virtual address: 0000000000000000; physical address: 0000000000000000 > As this section is ARM Processor Error Section, how about use arm_proc_err_event? This is not for the ARM Processor Error Section, that is what the arm_event is handling. What you are adding this trace support for here is called the ARM Processor Error Information (UEFI 2.6 spec section N.2.4.4.1). So I think your trace event here should be called arm_err_info_event. This will also be consistent with the other two trace events that I'm planning on adding: arm_ctx_info_event: ARM Processor Context Information (UEFI 2.6 section N.2.4.4.2) arm_vendor_info_event: This is the "Vendor Specific Error Information" in the ARM Processor Error Section (Table 260). It's possible I may just add this into the arm_event trace event, but I haven't looked into it enough yet. Thanks, Tyler -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.