Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755134AbdDQTDP (ORCPT ); Mon, 17 Apr 2017 15:03:15 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:34570 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754109AbdDQTDM (ORCPT ); Mon, 17 Apr 2017 15:03:12 -0400 Subject: Re: [PATCH] scsi: ibmvfc: don't check for failure from mempool_alloc() To: NeilBrown , "James E.J. Bottomley" , "Martin K. Petersen" References: <878tn9xb2m.fsf@notabene.neil.brown.name> Cc: Tyrel Datwyler , linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org From: Tyrel Datwyler Message-ID: <6b896452-e653-bc96-3c26-1deeae995890@gmail.com> Date: Mon, 17 Apr 2017 12:03:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <878tn9xb2m.fsf@notabene.neil.brown.name> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 32 On 04/09/2017 07:15 PM, NeilBrown wrote: > > mempool_alloc() cannot fail when passed GFP_NOIO or any > other gfp setting that is permitted to sleep. > So remove this pointless code. > > Signed-off-by: NeilBrown Acked-by: Tyrel Datwyler > --- > drivers/scsi/ibmvscsi/ibmvfc.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c > index 2c92dabb55f6..26cd3c28186a 100644 > --- a/drivers/scsi/ibmvscsi/ibmvfc.c > +++ b/drivers/scsi/ibmvscsi/ibmvfc.c > @@ -3910,12 +3910,6 @@ static int ibmvfc_alloc_target(struct ibmvfc_host *vhost, u64 scsi_id) > spin_unlock_irqrestore(vhost->host->host_lock, flags); > > tgt = mempool_alloc(vhost->tgt_pool, GFP_NOIO); > - if (!tgt) { > - dev_err(vhost->dev, "Target allocation failure for scsi id %08llx\n", > - scsi_id); > - return -ENOMEM; > - } > - > memset(tgt, 0, sizeof(*tgt)); > tgt->scsi_id = scsi_id; > tgt->new_scsi_id = scsi_id; >