Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932159AbdDQUog (ORCPT ); Mon, 17 Apr 2017 16:44:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45828 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755023AbdDQUoc (ORCPT ); Mon, 17 Apr 2017 16:44:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 37DA480469 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=davem@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 37DA480469 Date: Mon, 17 Apr 2017 16:44:27 -0400 (EDT) Message-Id: <20170417.164427.2187992626189209767.davem@redhat.com> To: stefan@agner.ch Cc: shc_work@mail.ru, jarod@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: cx89x0: move attribute declaration before struct keyword From: David Miller In-Reply-To: <6fbaa209a827778ff56a7ac3b36e5e17@agner.ch> References: <20170417062032.22764-1-stefan@agner.ch> <20170417.160942.2196583103295700079.davem@redhat.com> <6fbaa209a827778ff56a7ac3b36e5e17@agner.ch> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 17 Apr 2017 20:44:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 169 Lines: 8 From: Stefan Agner Date: Mon, 17 Apr 2017 13:31:28 -0700 > Given that, can you reconsider? Please put the attribute after the compete type. Thanks.