Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755556AbdDQVpD (ORCPT ); Mon, 17 Apr 2017 17:45:03 -0400 Received: from anholt.net ([50.246.234.109]:36138 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755168AbdDQVo7 (ORCPT ); Mon, 17 Apr 2017 17:44:59 -0400 From: Eric Anholt To: Sean Paul Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out. In-Reply-To: <20170417175846.quedtrtjmfmthv2g@art_vandelay> References: <20170417162603.12726-1-eric@anholt.net> <20170417175846.quedtrtjmfmthv2g@art_vandelay> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 17 Apr 2017 13:32:36 -0700 Message-ID: <874lxmixln.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1816 Lines: 46 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Sean Paul writes: > On Mon, Apr 17, 2017 at 09:26:03AM -0700, Eric Anholt wrote: >> We were returning without decrementing if the error happened, meaning >> that at the next submit we wouldn't try to bring up the power domain. >>=20 >> Signed-off-by: Eric Anholt > > This change looks good to me. It seems a little odd to wrap pm_runtime wh= ich > is already refcounted in another refcount, but I'm really not familiar wi= th > the driver, and I'm sure there's a good reason for it. > > Reviewed-by: Sean Paul Yeah, it's an unfortunate hack because the reset control is buried in the power domain driver on the RPi, so we have to get the power domain actually off (0 refcount) in order to reset the GPU. Yay for building around closed-source firmware :( --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlj1JmUACgkQtdYpNtH8 nuhIKRAAgRY0QZb/7HUOEgUUgwP3u2q8HD4ctZI9moHx1TzRixbByIMhwOy9V9ZH nlkmHdZ6iZCKbnSpkdwDbQ7J+6Q9bCYlBLdtxKVBvCRuQs9nlpkwd/sWx32E/hIE cYq7KlUjHf0UPMO5Rd8VTRYMWfwq9/vILHUDHX6va62HPKOI6pYpFZQ84HNc3JDv qOkG1JmlpHmjIG2C8Y22VSTKJGOFOP0K+c237Tk7IJQTmDgvqEsj+90qbPu5vevG cj2c3G962rYJ40SYNn2zgl1B+kYh5i+xps1YusvuTOWDFzwX3iqpECF/jTbq03VB DT6EtvNKRHOGtrjVDKLKvqBQ6Ic6aonIw/e4Z/QQDtR/YlqU/MH2JTqOOZQJjJh9 jo68NujwBt9rqYtAYXt4SnQ13Q/QTuN55McCAEl3bP9dfIggKHOWFFP+qz7/aRap pK35GhRgOTj+JovFbZglA5brWkeWD6pH7Z7ye23tn05PdWlTcgjQDfeoj2nJ8DEG q6Qyxc/0UjjoLQ/q8bjwPotDJt0hoUCbtMgKBIumv7j5rdS9ReOjiau7DARKw7PJ l96Zo4n263p84u1r9//Z9S4hrGKY4SqgB9FKuJELwIlsc2HKmXMV89h91vkCea8v UdNlcZqEhRCdvNF5vFQk1WNGZg8+CEtOf4IMwsmHcrDfAl8NLFA= =pxtq -----END PGP SIGNATURE----- --=-=-=--