Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263624AbTFBRIP (ORCPT ); Mon, 2 Jun 2003 13:08:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264792AbTFBRIP (ORCPT ); Mon, 2 Jun 2003 13:08:15 -0400 Received: from e2.ny.us.ibm.com ([32.97.182.102]:52385 "EHLO e2.ny.us.ibm.com") by vger.kernel.org with ESMTP id S263624AbTFBRIO (ORCPT ); Mon, 2 Jun 2003 13:08:14 -0400 Date: Mon, 2 Jun 2003 10:20:40 -0700 From: Greg KH To: LKML , Sensors , "Mark D. Studebaker" Subject: Re: [RFC PATCH] Re: [OOPS] w83781d during rmmod (2.5.69-bk17) Message-ID: <20030602172040.GC4992@kroah.com> References: <20030524183748.GA3097@earth.solarsys.private> <3ED8067E.1050503@paradyne.com> <20030601143808.GA30177@earth.solarsys.private> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030601143808.GA30177@earth.solarsys.private> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1519 Lines: 38 On Sun, Jun 01, 2003 at 10:38:08AM -0400, Mark M. Hoffman wrote: > > This fixes the oops during w83781d module removal by putting the > subclient registration back in. While I was in there, I split > w83781d_detect in half in an attempt to reduce the goto madness. > > So, the /sys tree looks like this, where 48 & 49 are the subclients. > There are no entries (besides name & power) for the subclients. > > /sys/bus/i2c/ > |-- devices > | |-- 0-002d -> ../../../devices/pci0/00:02.1/i2c-0/0-002d > | |-- 0-0048 -> ../../../devices/pci0/00:02.1/i2c-0/0-0048 > | `-- 0-0049 -> ../../../devices/pci0/00:02.1/i2c-0/0-0049 > `-- drivers > |-- i2c_adapter > `-- w83781d > |-- 0-002d -> ../../../../devices/pci0/00:02.1/i2c-0/0-002d > |-- 0-0048 -> ../../../../devices/pci0/00:02.1/i2c-0/0-0048 > `-- 0-0049 -> ../../../../devices/pci0/00:02.1/i2c-0/0-0049 > > Also, I fixed a bug where this driver would request and release an > ISA region, then poke around in that region, then finally request > it again. > > This patch against 2.5.70 works for me vs. an SMBus adapter. It needs > re-testing against an ISA adapter since my particular chip is SMBus only. I've applied this and will send it off to Linus in a bit. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/