Date: Tue, 18 Apr 2017 10:06:00 +1000
From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: clg@kaod.org, gwshan@linux.vnet.ibm.com, joel@jms.id.au,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/ncsi: fix checksum validation in response packet
Reply-To: Gavin Shan <gwshan@linux.vnet.ibm.com>
References: <1492160197-13816-1-git-send-email-clg@kaod.org>
 <20170417.133619.1515025171498720534.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170417.133619.1515025171498720534.davem@davemloft.net>
User-Agent: Mutt/1.5.24 (2015-08-30)
Message-Id: <20170418000600.GA4978@gwshan>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 690
Lines: 20

On Mon, Apr 17, 2017 at 01:36:19PM -0400, David Miller wrote:
>From: C?dric Le Goater <clg@kaod.org>
>Date: Fri, 14 Apr 2017 10:56:37 +0200
>
>> htonl was used instead of ntohl. Surely a typo.
>> 
>> Signed-off-by: C?dric Le Goater <clg@kaod.org>
>
>I don't think so, "checksum" is of type "u32" thus is in host byte
>order.  Therefore "htonl()" is correct.
>

Yeah, "htonl()" is correct here. "*pchecksum" is in big-endian.
I want to know how C?dric thinks it's a problem. I guess he might
encounter the issue on the emulated NCSI channel by QEMU. On BCM5718
or BCM5719, the checksum in AEN and response packet are zero'd, meaning
the software shouldn't validate it at all.

Thanks,
Gavin