Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755753AbdDRC1O (ORCPT ); Mon, 17 Apr 2017 22:27:14 -0400 Received: from regular1.263xmail.com ([211.150.99.136]:33151 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753721AbdDRC1M (ORCPT ); Mon, 17 Apr 2017 22:27:12 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: sugar.zhang@rock-chips.com X-FST-TO: ulysses.huang@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: sugar.zhang@rock-chips.com X-UNIQUE-TAG: <6b4a313d0d402858b027ea35cb655293> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: sugar Subject: Re: [PATCH 0/2] Free running cyclic transfer implementation for pl330 To: Alexander Kochetkov , Dan Williams , Vinod Koul , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, hhb@rock-chips.com, shawn.lin@rock-chips.com, caesar.wang@rock-chips.com, ulysses.huang@rock-chips.com References: <1492180531-1780-1-git-send-email-al.kochet@gmail.com> Message-ID: <52e886e1-88f7-808d-4838-b5c136f44651@rock-chips.com> Date: Tue, 18 Apr 2017 10:26:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1492180531-1780-1-git-send-email-al.kochet@gmail.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1345 Lines: 37 Hi Alexander, I have tested this series on rk3399 evb board and works well. Tested-by: Sugar Zhang ?? 4/14/2017 22:35, Alexander Kochetkov ะด??: > Hello! > > This series contain free running cyclic transfer implementation for pl330. > It affect ALL chips using pl330 (not only rockchip) and > allow to run cyclic transfers without CPU intervention. As a result > it fix sound clicks (observed and not yet observed) because > sound clicks must be heard under heavy system load due to the way > how cyclic transfers implemented now for pl330. > > My previous series[1] doesn't get enough attention (no one except me > tested it). And it don't get upstream: > >> 8-03-2016, 6:03, Vinod Koul *: >> Overall this series looks okay, but can someone test this. I would not like > pl330 to be broken again > > Now I was asked about the series[1] again by guys from Rockchip, > so I send rebased against 4.10.10 version. Hope, someone might test it > and confirm that patches work fine. > > Regards, > Alexander. > > Alexander Kochetkov (2): > dmaengine: pl330: make cyclic transfer free runnable > dmaengine: pl330: don't emit code for one iteration loop > > drivers/dma/pl330.c | 200 +++++++++++++++++++++++++-------------------------- > 1 file changed, 98 insertions(+), 102 deletions(-) >