DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 755A619D241
Message-ID: <1492510440.27392.27.camel@redhat.com>
Subject: Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments
 in line with reality.
From: Gerd Hoffmann <kraxel@redhat.com>
To: Michel =?ISO-8859-1?Q?D=E4nzer?= <michel@daenzer.net>
Cc: Ilia Mirkin <imirkin@alum.mit.edu>, amd-gfx@lists.freedesktop.org,
        open list <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Daniel Vetter <daniel.vetter@intel.com>
Date: Tue, 18 Apr 2017 12:14:00 +0200
In-Reply-To: <fe944ecc-3ca4-26d8-77bc-873a53dcbb3f@daenzer.net>
References: <20170410101202.19229-1-kraxel@redhat.com>
         <20170410161214.305f5daf@eldfell> <1491833847.30990.77.camel@redhat.com>
         <20170410180941.43922e25@eldfell>
         <CAKb7UvhbgSGwx-2EsrQrHmghzYqO9AhRQ10bDWKfdcXHc3fJeQ@mail.gmail.com>
         <20170411103101.0497fe08@eldfell>
         <CAKb7UviNeLJAHtBQt2NgbEMOSz1sYneiB7i0CUDOBQRt=8OqNw@mail.gmail.com>
         <CAKb7UvgVD3Uf79noXMOcBjJYeeF6st21R3JBNvT-VVSNb8EH+Q@mail.gmail.com>
         <e94bde35-d3f5-fa98-cc64-6d48b37ec21f@daenzer.net>
         <CAKb7UviAoSh6F1v9kCThayVwnWKKi+w1KDLTHHGsLeS95o+Pjg@mail.gmail.com>
         <fe944ecc-3ca4-26d8-77bc-873a53dcbb3f@daenzer.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 477
Lines: 15

  Hi,

> > Quite true that this proves nothing. However one should note that
> > fbcon -> fbdev works,
> 
> BTW, this supports Gerd's patch, since the KMS fbdev emulation code uses
> e.g. DRM_FORMAT_XRGB8888 for depth/bpp 24/32, and the fbdev API uses
> native endian packed colour values.

Same is true for DRM_IOCTL_MODE_ADDFB, with depth/bpp 24/32 you'll get
DRM_FORMAT_XRGB8888 (only DRM_IOCTL_MODE_ADDFB2 allows userspace specify
fourcc formats directly).

cheers,
  Gerd