Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757038AbdDRLfG (ORCPT ); Tue, 18 Apr 2017 07:35:06 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:49936 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752209AbdDRLfD (ORCPT ); Tue, 18 Apr 2017 07:35:03 -0400 Date: Tue, 18 Apr 2017 14:33:41 +0300 From: Yuval Shaia To: SF Markus Elfring Cc: linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, David Ahern , Doug Ledford , Erez Shitrit , Feras Daoud , Hal Rosenstock , Leon Romanovsky , Mark Bloch , Or Gerlitz , Paolo Abeni , Roi Dayan , Sagi Grimberg , Sean Hefty , Zhu Yanjun , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 5/9] IB/IPoIB: Combine substrings for three messages Message-ID: <20170418113340.GE4045@yuval-lap> References: <8267b19e-d6a6-ac77-6b0e-e184e690db9b@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8267b19e-d6a6-ac77-6b0e-e184e690db9b@users.sourceforge.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2289 Lines: 59 On Fri, Apr 07, 2017 at 11:05:23PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 7 Apr 2017 21:06:08 +0200 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: quoted string split across lines > > Thus fix affected source code places. > > Signed-off-by: Markus Elfring Reviewed-by: Yuval Shaia > --- > drivers/infiniband/ulp/ipoib/ipoib_main.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c > index 55581417eb43..43aef0ca53ad 100644 > --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c > @@ -226,8 +226,9 @@ static int ipoib_change_mtu(struct net_device *dev, int new_mtu) > priv->admin_mtu = new_mtu; > > if (priv->mcast_mtu < priv->admin_mtu) > - ipoib_dbg(priv, "MTU must be smaller than the underlying " > - "link layer MTU - 4 (%u)\n", priv->mcast_mtu); > + ipoib_dbg(priv, > + "MTU must be smaller than the underlying link layer MTU - 4 (%u)\n", > + priv->mcast_mtu); > > dev->mtu = min(priv->mcast_mtu, priv->admin_mtu); > > @@ -480,8 +481,8 @@ int ipoib_set_mode(struct net_device *dev, const char *buf) > /* flush paths if we switch modes so that connections are restarted */ > if (IPOIB_CM_SUPPORTED(dev->dev_addr) && !strcmp(buf, "connected\n")) { > set_bit(IPOIB_FLAG_ADMIN_CM, &priv->flags); > - ipoib_warn(priv, "enabling connected mode " > - "will cause multicast packet drops\n"); > + ipoib_warn(priv, > + "enabling connected mode will cause multicast packet drops\n"); > netdev_update_features(dev); > dev_set_mtu(dev, ipoib_cm_max_mtu(dev)); > rtnl_unlock(); > @@ -1855,8 +1856,8 @@ void ipoib_set_umcast(struct net_device *ndev, int umcast_val) > > if (umcast_val > 0) { > set_bit(IPOIB_FLAG_UMCAST, &priv->flags); > - ipoib_warn(priv, "ignoring multicast groups joined directly " > - "by userspace\n"); > + ipoib_warn(priv, > + "ignoring multicast groups joined directly by userspace\n"); > } else > clear_bit(IPOIB_FLAG_UMCAST, &priv->flags); > } > -- > 2.12.2 >