Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755854AbdDRM3Q convert rfc822-to-8bit (ORCPT ); Tue, 18 Apr 2017 08:29:16 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:56068 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752425AbdDRM3N (ORCPT ); Tue, 18 Apr 2017 08:29:13 -0400 Date: Tue, 18 Apr 2017 14:29:03 +0200 From: Cornelia Huck To: David Hildenbrand Cc: Radim =?UTF-8?B?S3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Christoffer Dall , Marc Zyngier , Paolo Bonzini , Christian Borntraeger , James Hogan , Paul Mackerras , Alexander Graf Subject: Re: [PATCH 0/4] KVM: add KVM_CREATE_VM2 to allow dynamic kvm->vcpus array In-Reply-To: References: <20170413201951.11939-1-rkrcmar@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 17041812-0016-0000-0000-0000047F0681 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17041812-0017-0000-0000-00002749B5F8 Message-Id: <20170418142903.44973c86.cornelia.huck@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-18_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704180102 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2030 Lines: 51 On Tue, 18 Apr 2017 13:11:55 +0200 David Hildenbrand wrote: > On 13.04.2017 22:19, Radim Krčmář wrote: > > The basic idea is to let userspace provide the desired maximal number of > > VCPUs and allocate only necessary memory for them. > > > > The goal is to freeze KVM_MAX_VCPUS at its current level and only increase the > > KVM_MAX_VCPUS might still increase e.g. if hw support for more VCPUs is > comming. > > > new KVM_MAX_CONFIGURABLE_VCPUS, probably directly to INT_MAX/KVM_VCPU_ID, so we > > don't have to worry about it for a while. > > > > PPC should be interested in this as they set KVM_MAX_VCPUS to NR_CPUS > > and probably waste few pages for every guest this way. > > As we just store pointers, this should be a maximum of 4 pages for ppc > (4k pages). Is this really worth yet another VM creation ioctl? Is there > not a nicer way to handle this internally? > > An alternative might be to simply realloc the array when it reaches a > certain size (on VCPU creation, maybe protecting the pointer via rcu). > But not sure if something like that could work. I like that idea better, if it does work (I think it should be doable). If we just double the array size every time we run out of space, we should be able to do this with few reallocations. That has also the advantage of being transparent to user space (other than increased number of vcpus). > > > > > > > Radim Krčmář (4): > > KVM: remove unused __KVM_HAVE_ARCH_VM_ALLOC > > KVM: allocate kvm->vcpus separately > > KVM: add KVM_CREATE_VM2 system ioctl > > KVM: x86: enable configurable MAX_VCPU > > > > Documentation/virtual/kvm/api.txt | 28 +++++++++++++++ > > arch/x86/include/asm/kvm_host.h | 1 + > > arch/x86/kvm/irq_comm.c | 4 +-- > > include/linux/kvm_host.h | 23 +++++------- > > include/uapi/linux/kvm.h | 8 +++++ > > virt/kvm/kvm_main.c | 76 +++++++++++++++++++++++++++++++++------ > > 6 files changed, 114 insertions(+), 26 deletions(-) > > > >