Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753446AbdDRNzM (ORCPT ); Tue, 18 Apr 2017 09:55:12 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:65379 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbdDRNzL (ORCPT ); Tue, 18 Apr 2017 09:55:11 -0400 From: "Rafael J. Wysocki" To: Darren Hart Cc: LKML , Linux PM , platform-driver-x86@vger.kernel.org, Andy Shevchenko Subject: [PATCH] platform: x86: intel-hid: Add missing ->thaw callback Date: Tue, 18 Apr 2017 15:49:06 +0200 Message-ID: <3369188.n8HfSBcO3V@aspire.rjw.lan> User-Agent: KMail/4.14.10 (Linux/4.11.0-rc6+; KDE/4.14.9; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1198 Lines: 29 From: Rafael J. Wysocki The intel-hid driver is missing a PM ->thaw callback allowing the device to go back to the operational state after creating a hibernation image or when there is an image restoration error during resume. The lack of the ->thaw callback basically means that all events signaled by the device are discarded after a hibernation image has been created which may be problematic, for example, if the image cannot be saved (eg. due to an I/O issue with storage). Signed-off-by: Rafael J. Wysocki --- drivers/platform/x86/intel-hid.c | 1 + 1 file changed, 1 insertion(+) Index: linux-pm/drivers/platform/x86/intel-hid.c =================================================================== --- linux-pm.orig/drivers/platform/x86/intel-hid.c +++ linux-pm/drivers/platform/x86/intel-hid.c @@ -136,6 +136,7 @@ static int intel_hid_pl_resume_handler(s static const struct dev_pm_ops intel_hid_pl_pm_ops = { .freeze = intel_hid_pl_suspend_handler, + .thaw = intel_hid_pl_resume_handler, .restore = intel_hid_pl_resume_handler, .suspend = intel_hid_pl_suspend_handler, .resume = intel_hid_pl_resume_handler,