Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755937AbdDRPBq (ORCPT ); Tue, 18 Apr 2017 11:01:46 -0400 Received: from mail.visioncatalog.com ([217.6.246.34]:56661 "EHLO root.phytec.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752531AbdDRPBn (ORCPT ); Tue, 18 Apr 2017 11:01:43 -0400 Subject: Re: [PATCH v2 1/3] ARM: dts: rockchip: Add support for phyCORE-RK3288 SoM To: Jacob Chen References: <1491483866-18368-1-git-send-email-w.egorov@phytec.de> Cc: robh+dt@kernel.org, mark.rutland@arm.com, Heiko Stuebner , linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Wadim Egorov Message-ID: <381e11bc-649d-ddf2-4a28-f72a264204c3@phytec.de> Date: Tue, 18 Apr 2017 17:01:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: X-MIMETrack: Itemize by SMTP Server on Idefix/Phytec(Release 9.0.1FP7|August 17, 2016) at 18.04.2017 17:01:41, Serialize by Router on Idefix/Phytec(Release 9.0.1FP7|August 17, 2016) at 18.04.2017 17:01:41, Serialize complete at 18.04.2017 17:01:41 X-TNEFEvaluated: 1 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 632 Lines: 18 >> +&i2c0 { >> + status = "okay"; >> + clock-frequency = <400000>; >> + >> + rk818: pmic@1c { >> + compatible = "rockchip,rk818"; >> + reg = <0x1c>; >> + interrupt-parent = <&gpio0>; >> + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pmic_int>; >> + rockchip,system-power-controller; >> + wakeup-source; >> + #clock-cells = <1>; >> + > I think you miss "clock-output-names = "xin32k" here. Yes, thanks for catching that. I will fix this later.