Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757383AbdDRPuc (ORCPT ); Tue, 18 Apr 2017 11:50:32 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:59743 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753209AbdDRPu2 (ORCPT ); Tue, 18 Apr 2017 11:50:28 -0400 X-ME-Sender: X-Sasl-enc: 6vzhylWAuBGttrQcOEitL06JVXVI+6r/VYStumsZF8Z/ 1492530627 Date: Tue, 18 Apr 2017 17:50:19 +0200 From: "greg@kroah.com" To: Rishiraj Manwatkar Cc: "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "andreas.dilger@intel.com" , "oleg.drokin@intel.com" Subject: Re: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues Message-ID: <20170418155019.GA7263@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.1 (2017-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 954 Lines: 26 On Sat, Apr 15, 2017 at 01:50:42PM +0000, Rishiraj Manwatkar wrote: > Parantheses are added for Macro argument, to avoid precedence issues. > > Signed-off-by: Rishiraj Manwatkar > --- > v1 -> v2: Added mailing list in cc. > v2 -> v3: Changed From: to be same as Signed-off-by:. > drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c > index ee7d677..0997254 100755 > --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c > +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c > @@ -52,9 +52,9 @@ > */ > > #define cl_io_for_each(slice, io) \ > - list_for_each_entry((slice), &io->ci_layers, cis_linkage) > + list_for_each_entry((slice), &(io)->ci_layers, cis_linkage) Really? There is no precedence issues that I can see here, sorry. thanks, greg k-h