Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755828AbdDRQjL (ORCPT ); Tue, 18 Apr 2017 12:39:11 -0400 Received: from gagarine.paulk.fr ([109.190.93.129]:61951 "EHLO gagarine.paulk.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752748AbdDRQjG (ORCPT ); Tue, 18 Apr 2017 12:39:06 -0400 Message-ID: <1492533513.3504.2.camel@paulk.fr> Subject: Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for tegra124 SoC From: Paul Kocialkowski To: Stephen Warren , linux-kernel@vger.kernel.org, Thierry Reding Cc: alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org, Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Alexandre Courbot , Marcel Ziswiler , Rob Herring Date: Tue, 18 Apr 2017 18:38:33 +0200 In-Reply-To: References: <20170418151159.31843-1-contact@paulk.fr> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-f/OzAaO+fA7fBAUdo+Fc" X-Mailer: Evolution 3.22.6 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2849 Lines: 75 --=-f/OzAaO+fA7fBAUdo+Fc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le mardi 18 avril 2017 =C3=A0 10:15 -0600, Stephen Warren a =C3=A9crit=C2= =A0: > On 04/18/2017 09:11 AM, Paul Kocialkowski wrote: > > This selects the tegra30 i2s and ahub controllers for the tegra124 SoC. > > These are needed when building without ARCH_TEGRA_3x_SOC set. > > diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig > > index efbe8d4c019e..bcd18d2cf7a7 100644 > > --- a/sound/soc/tegra/Kconfig > > +++ b/sound/soc/tegra/Kconfig > > @@ -46,7 +46,7 @@ config SND_SOC_TEGRA20_SPDIF > >=20 > > =C2=A0config SND_SOC_TEGRA30_AHUB > > =C2=A0 tristate > > - depends on SND_SOC_TEGRA && ARCH_TEGRA_3x_SOC > > + depends on SND_SOC_TEGRA && (ARCH_TEGRA_3x_SOC || > > ARCH_TEGRA_124_SOC) >=20 > Is this really a compile-time dependency? =46rom a quick look at the code, I doubt this is really a build dependency. > If so, don't we need to add=C2=A0T210 and T186 entries into that || condi= tion too, > since we could be=C2=A0building a kernel with just T210/T186 support and = no T124 > support? In the spirit of this patch, adding entries for other tegra platforms would= make sense.=C2=A0Would you prefer that we leave out the dependency from SND_SOC_= TEGRA30_* and only select the right I2S driver to use in each codec driver? If not, we'd have to list all relevant platforms both in the I2S/AHUB drive= rs and in each codec's rules (which is not necessarily and issue, but there's = no need to have artificial platform dependencies). What do you think? --=20 Paul Kocialkowski, developer of free digital technology at the lower levels Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/ --=-f/OzAaO+fA7fBAUdo+Fc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEAbcMXZQMtj1fphLChP3B6o/ulQwFAlj2QQoACgkQhP3B6o/u lQwD6Q//byGzV+L88nNVaAY8tSkMSF5zlys3oNDf/+XC37FtF6+iYpplARrMwhjA JBP2VwFGyhX+Frwtv7xnN6tHfdW4fr2pRInXTOsUz4jhu65MFs79nPF04KR+cswn QFJz1lxYyGJzSDHAeGfG4otDHNfI1A80uOScy3kYFzbq0OZ5Rqm2eBtsyjtu/StD pogHkmsmVq37SnupdB1EPtIRNzo3iWWucDgulYR4fbqdPbOxjN9FOL3Y2HwUMjLQ iJwlETbs9k3amTSoYukwkqG0HvHDtCVsJJTc6pYwcjHdh6LtedCheL4LU6Z56D5v 7Y89k5LFT88km889wUeq+qlbwzpdFSNfkUQvAPZ5HrUjkdgZuzW+QA32Q2xsassw pMPeXGf89oZ3yeW2+/sV7S9sj3LFK6Mp/zzrtMlaW8VRkzQES2PX61eI2+PzYOi0 SMixoKupupoTGz+5rKdu4aXiegdJb7Das/rGhpQMYdSGafL+7Vu7ywAMIs5H53nx FjJFHYwl+ov4EF9uVDFQj2Bxv67O+6afAqioiY6oH8pG5YwiMrN2PSTEB2YaZuNA IbU4FWzT+zWV8T1feCrfWt9ouGezJVSb2MvGnwh/DlrEWa4XqSWOFWL6PD1OT6Ux BimxlPbddyO0hvJOCdu3KKvvsss7FyzKQD5ceX1UpqRALaD9e8k= =zmwf -----END PGP SIGNATURE----- --=-f/OzAaO+fA7fBAUdo+Fc--