Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757599AbdDRRav (ORCPT ); Tue, 18 Apr 2017 13:30:51 -0400 Received: from mail-qt0-f170.google.com ([209.85.216.170]:34720 "EHLO mail-qt0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752255AbdDRRat (ORCPT ); Tue, 18 Apr 2017 13:30:49 -0400 MIME-Version: 1.0 In-Reply-To: <20170418160735.GB25405@fury> References: <3369188.n8HfSBcO3V@aspire.rjw.lan> <20170418160735.GB25405@fury> From: Alex Hung Date: Tue, 18 Apr 2017 10:30:47 -0700 Message-ID: Subject: Re: [PATCH] platform: x86: intel-hid: Add missing ->thaw callback To: Darren Hart Cc: "Rafael J. Wysocki" , LKML , Linux PM , "platform-driver-x86@vger.kernel.org" , Andy Shevchenko Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1654 Lines: 51 On Tue, Apr 18, 2017 at 9:07 AM, Darren Hart wrote: > On Tue, Apr 18, 2017 at 03:49:06PM +0200, Rafael Wysocki wrote: >> From: Rafael J. Wysocki >> >> The intel-hid driver is missing a PM ->thaw callback allowing the >> device to go back to the operational state after creating a >> hibernation image or when there is an image restoration error during >> resume. >> >> The lack of the ->thaw callback basically means that all events >> signaled by the device are discarded after a hibernation image has >> been created which may be problematic, for example, if the image >> cannot be saved (eg. due to an I/O issue with storage). >> >> Signed-off-by: Rafael J. Wysocki > > + Alex Hung > > Queued to testing, thank you Rafael. Thank you Rafael for catching this. > >> --- >> drivers/platform/x86/intel-hid.c | 1 + >> 1 file changed, 1 insertion(+) >> >> Index: linux-pm/drivers/platform/x86/intel-hid.c >> =================================================================== >> --- linux-pm.orig/drivers/platform/x86/intel-hid.c >> +++ linux-pm/drivers/platform/x86/intel-hid.c >> @@ -136,6 +136,7 @@ static int intel_hid_pl_resume_handler(s >> >> static const struct dev_pm_ops intel_hid_pl_pm_ops = { >> .freeze = intel_hid_pl_suspend_handler, >> + .thaw = intel_hid_pl_resume_handler, >> .restore = intel_hid_pl_resume_handler, >> .suspend = intel_hid_pl_suspend_handler, >> .resume = intel_hid_pl_resume_handler, >> >> > > -- > Darren Hart > VMware Open Source Technology Center -- Cheers, Alex Hung