Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754757AbdDRSpU (ORCPT ); Tue, 18 Apr 2017 14:45:20 -0400 Received: from mail.kernel.org ([198.145.29.136]:34714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975AbdDRSpT (ORCPT ); Tue, 18 Apr 2017 14:45:19 -0400 Date: Tue, 18 Apr 2017 13:45:15 -0500 From: Bjorn Helgaas To: Christoph Hellwig Cc: Thomas Gleixner , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: provide pci_request_irq / pci_free_irq helpers Message-ID: <20170418184515.GD25295@bhelgaas-glaptop.roam.corp.google.com> References: <20170413070643.32165-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170413070643.32165-1-hch@lst.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 15 On Thu, Apr 13, 2017 at 09:06:39AM +0200, Christoph Hellwig wrote: > PCI drivers that support multiple MSI or MSI-X vectors currently have a > lot of boileplate code to generate names for each vector (or simply use > the same name for all of them, which isn't nice either). This series > adds new helpers that allocate and free a name based on a format string > passed to the request_irq wrapper. > > They also hide the [pci_dev,vector] to Linux irq number translation, > in fact the example NVMe driver conversion now never sees the Linux irq > number. That might be useful to isolate PCI drivers from our IRQ numbers, > although to have a full abstraction we'd need similar wrappers for > {enable,disable,synchronize}_irq as well. Applied with reviewed-by from Thomas and Keith to pci/irq for v4.12, thanks!