Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757898AbdDRVBa (ORCPT ); Tue, 18 Apr 2017 17:01:30 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:33831 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756856AbdDRVB0 (ORCPT ); Tue, 18 Apr 2017 17:01:26 -0400 Date: Tue, 18 Apr 2017 14:01:24 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Anshuman Khandual cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org Subject: Re: [PATCH V3] mm/madvise: Move up the behavior parameter validation In-Reply-To: <20170418052844.24891-1-khandual@linux.vnet.ibm.com> Message-ID: References: <20170413092008.5437-1-khandual@linux.vnet.ibm.com> <20170418052844.24891-1-khandual@linux.vnet.ibm.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 472 Lines: 12 On Tue, 18 Apr 2017, Anshuman Khandual wrote: > The madvise_behavior_valid() function should be called before > acting upon the behavior parameter. Hence move up the function. > This also includes MADV_SOFT_OFFLINE and MADV_HWPOISON options > as valid behavior parameter for the system call madvise(). > > Signed-off-by: Anshuman Khandual Acked-by: David Rientjes Looks like this depends on existing patches in -mm.