Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755401AbdDRWaC (ORCPT ); Tue, 18 Apr 2017 18:30:02 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:35968 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbdDRW37 (ORCPT ); Tue, 18 Apr 2017 18:29:59 -0400 Subject: Re: [PATCH 2/2] hwmon: (brcmstb) Add driver for Broadcom STB DPFE To: Guenter Roeck , Markus Mayer References: <20170418201702.57019-1-code@mmayer.net> <20170418201702.57019-3-code@mmayer.net> <20170418205839.GA3554@roeck-us.net> Cc: Jean Delvare , Rob Herring , Mark Rutland , Markus Mayer , Broadcom Kernel List , Linux HWMON List , Device Tree List , ARM Kernel List , Linux Kernel Mailing List From: Florian Fainelli Message-ID: Date: Tue, 18 Apr 2017 15:29:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170418205839.GA3554@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1729 Lines: 48 Hey Guenter, On 04/18/2017 01:58 PM, Guenter Roeck wrote: > Hi Markus, > > On Tue, Apr 18, 2017 at 01:17:02PM -0700, Markus Mayer wrote: >> From: Markus Mayer >> >> This driver allows access to DRAM properties, such as the refresh rate, >> via the Broadcom STB DDR PHY Front End (DPFE). The refresh rate can be >> used as indirect indicator of the DRAM temperature. >> >> The driver also allows setting of the sampling interval. >> >> Signed-off-by: Markus Mayer >> --- > [ ... ] > >> + >> +static SENSOR_DEVICE_ATTR(dpfe_info, 0444, show_info, NULL, 1000); >> +static SENSOR_DEVICE_ATTR(dpfe_refresh, 0644, show_refresh, store_refresh, >> + 1000); >> +static SENSOR_DEVICE_ATTR(dpfe_vendor, 0444, show_vendor, NULL, 1000); >> +static struct attribute *dpfe_attrs[] = { >> + &sensor_dev_attr_dpfe_info.dev_attr.attr, >> + &sensor_dev_attr_dpfe_refresh.dev_attr.attr, >> + &sensor_dev_attr_dpfe_vendor.dev_attr.attr, >> + NULL >> +}; >> +ATTRIBUTE_GROUPS(dpfe); >> + > > There is not a single standard hwmon attribute. I don't know how > to classify this driver, and where it should reside, but it is not > a hwmon driver. This is a driver that talks to an embedded CPU running firmware which is capable of giving various informations about the DRAM chip being populated, including a temperature trend (hotter or cooler). We thought initially we would be able to expose the actual temperature, but this in turn required a lot more knowledge about the DRAM chip that we wish we knew about. That is sort of where and why this driver was proposed for hwmon. Which subsystem do you think would be best for this driver drivers/misc/ or drivers/soc/bcm/brcmstb/ maybe? -- Florian