Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758134AbdDSBCG (ORCPT ); Tue, 18 Apr 2017 21:02:06 -0400 Received: from mail.netline.ch ([148.251.143.178]:60775 "EHLO netline-mail3.netline.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752309AbdDSBCD (ORCPT ); Tue, 18 Apr 2017 21:02:03 -0400 Subject: Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality. To: Gerd Hoffmann Cc: Daniel Vetter , "dri-devel@lists.freedesktop.org" , amd-gfx@lists.freedesktop.org, open list References: <20170410101202.19229-1-kraxel@redhat.com> <20170410161214.305f5daf@eldfell> <1491833847.30990.77.camel@redhat.com> <20170410180941.43922e25@eldfell> <20170411103101.0497fe08@eldfell> <1492510440.27392.27.camel@redhat.com> From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Message-ID: <4230c093-6a8a-76d6-dce8-f9b2300fa70f@daenzer.net> Date: Wed, 19 Apr 2017 10:01:47 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1492510440.27392.27.camel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 21 On 18/04/17 07:14 PM, Gerd Hoffmann wrote: > Hi, > >>> Quite true that this proves nothing. However one should note that >>> fbcon -> fbdev works, >> >> BTW, this supports Gerd's patch, since the KMS fbdev emulation code uses >> e.g. DRM_FORMAT_XRGB8888 for depth/bpp 24/32, and the fbdev API uses >> native endian packed colour values. > > Same is true for DRM_IOCTL_MODE_ADDFB, with depth/bpp 24/32 you'll get > DRM_FORMAT_XRGB8888 (only DRM_IOCTL_MODE_ADDFB2 allows userspace specify > fourcc formats directly). Right, and since all major Xorg drivers use DRM_IOCTL_MODE_ADDFB, they're effectively using DRM_FORMAT_XRGB8888 as native endianness as well. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer