Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758694AbdDSBVX convert rfc822-to-8bit (ORCPT ); Tue, 18 Apr 2017 21:21:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:27363 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757999AbdDSBVT (ORCPT ); Tue, 18 Apr 2017 21:21:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,219,1488873600"; d="scan'208";a="91481959" From: "Dilger, Andreas" To: "greg@kroah.com" CC: Rishiraj Manwatkar , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Drokin, Oleg" Subject: Re: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues Thread-Topic: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues Thread-Index: AQHSte9FeVbklVYGq0GJPNI96bLsqaHLwG+AgACfeAA= Date: Wed, 19 Apr 2017 01:21:04 +0000 Message-ID: <288867FC-FBC8-4E2B-B018-409822B24232@intel.com> References: <20170418155019.GA7263@kroah.com> In-Reply-To: <20170418155019.GA7263@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.199.57] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1517 Lines: 51 On Apr 18, 2017, at 09:50, greg@kroah.com wrote: > > On Sat, Apr 15, 2017 at 01:50:42PM +0000, Rishiraj Manwatkar wrote: >> Subject: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues (typo) s/Parantheses/parenthesis/ s/Macro/macro/ The Subject line (excluding [PATCH] part) should be under 60 >> Parantheses are added for Macro argument, to avoid precedence issues. Should be something like: Subject: [PATCH v4 1/2] staging/lustre: add parenthesis to macro arguments Add parenthesis to cl_io_for_each() macro to avoid potential issues with unexpected argument expansion in CPP. >> Signed-off-by: Rishiraj Manwatkar >> --- >> v1 -> v2: Added mailing list in cc. >> v2 -> v3: Changed From: to be same as Signed-off-by:. >> drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c >> index ee7d677..0997254 100755 >> --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c >> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c >> @@ -52,9 +52,9 @@ >> */ >> >> #define cl_io_for_each(slice, io) \ >> - list_for_each_entry((slice), &io->ci_layers, cis_linkage) >> + list_for_each_entry((slice), &(io)->ci_layers, cis_linkage) > > Really? There is no precedence issues that I can see here, sorry. Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation