Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759382AbdDSDT0 (ORCPT ); Tue, 18 Apr 2017 23:19:26 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:34007 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758816AbdDSDTY (ORCPT ); Tue, 18 Apr 2017 23:19:24 -0400 MIME-Version: 1.0 In-Reply-To: <4230c093-6a8a-76d6-dce8-f9b2300fa70f@daenzer.net> References: <20170410101202.19229-1-kraxel@redhat.com> <20170410161214.305f5daf@eldfell> <1491833847.30990.77.camel@redhat.com> <20170410180941.43922e25@eldfell> <20170411103101.0497fe08@eldfell> <1492510440.27392.27.camel@redhat.com> <4230c093-6a8a-76d6-dce8-f9b2300fa70f@daenzer.net> From: Ilia Mirkin Date: Tue, 18 Apr 2017 23:19:22 -0400 X-Google-Sender-Auth: VoSr24-LlQLeasjDSoz8BdHLa-w Message-ID: Subject: Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality. To: =?UTF-8?Q?Michel_D=C3=A4nzer?= Cc: Gerd Hoffmann , Daniel Vetter , amd-gfx@lists.freedesktop.org, "dri-devel@lists.freedesktop.org" , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v3J3JVKX023590 Content-Length: 1199 Lines: 27 On Tue, Apr 18, 2017 at 9:01 PM, Michel Dänzer wrote: > On 18/04/17 07:14 PM, Gerd Hoffmann wrote: >> Hi, >> >>>> Quite true that this proves nothing. However one should note that >>>> fbcon -> fbdev works, >>> >>> BTW, this supports Gerd's patch, since the KMS fbdev emulation code uses >>> e.g. DRM_FORMAT_XRGB8888 for depth/bpp 24/32, and the fbdev API uses >>> native endian packed colour values. >> >> Same is true for DRM_IOCTL_MODE_ADDFB, with depth/bpp 24/32 you'll get >> DRM_FORMAT_XRGB8888 (only DRM_IOCTL_MODE_ADDFB2 allows userspace specify >> fourcc formats directly). > > Right, and since all major Xorg drivers use DRM_IOCTL_MODE_ADDFB, > they're effectively using DRM_FORMAT_XRGB8888 as native endianness as well. In the meanwhile, it has been pointed out to me that pre-nv50 display code actually doesn't use DRM_FORMAT_* at all -- it uses some helpers which end up advertising XR24 / AR24. However from what I can tell, that's not a well-reasoned selection. Either way, I'm going to test Gerd's patch, hopefully during the week, or weekend at the latest. My current suspicion is that it will have no effect on nouveau either way. We'll find out. -ilia