Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933681AbdDSIXw (ORCPT ); Wed, 19 Apr 2017 04:23:52 -0400 Received: from foss.arm.com ([217.140.101.70]:37060 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933278AbdDSIXr (ORCPT ); Wed, 19 Apr 2017 04:23:47 -0400 Date: Wed, 19 Apr 2017 09:23:18 +0100 From: Mark Rutland To: SF Markus Elfring Cc: Ingo Molnar , Pawel Moll , Sebastian Andrzej Siewior , "Suzuki K. Poulose" , Thomas Gleixner , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] bus: arm-ccn: Use devm_kcalloc() in arm_ccn_probe() Message-ID: <20170419082317.GA27829@leverpostej> References: <3458009f-6489-da7f-c1c1-c834d5b9d41d@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3458009f-6489-da7f-c1c1-c834d5b9d41d@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1431 Lines: 46 On Wed, Apr 19, 2017 at 09:29:24AM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 19 Apr 2017 09:12:43 +0200 > > Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. > Thus use the corresponding function "devm_kcalloc". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring This looks reasonable to me. FWIW: Acked-by: Mark Rutland I'll leave the final say to Pawel. Mark. > --- > drivers/bus/arm-ccn.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c > index 4d6a2b7e4d3f..6375bda0b2a1 100644 > --- a/drivers/bus/arm-ccn.c > +++ b/drivers/bus/arm-ccn.c > @@ -1520,10 +1520,10 @@ static int arm_ccn_probe(struct platform_device *pdev) > if (err) > return err; > > - ccn->node = devm_kzalloc(ccn->dev, sizeof(*ccn->node) * ccn->num_nodes, > - GFP_KERNEL); > - ccn->xp = devm_kzalloc(ccn->dev, sizeof(*ccn->node) * ccn->num_xps, > - GFP_KERNEL); > + ccn->node = devm_kcalloc(ccn->dev, ccn->num_nodes, sizeof(*ccn->node), > + GFP_KERNEL); > + ccn->xp = devm_kcalloc(ccn->dev, ccn->num_xps, sizeof(*ccn->node), > + GFP_KERNEL); > if (!ccn->node || !ccn->xp) > return -ENOMEM; > > -- > 2.12.2 >