Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934445AbdDSNNk (ORCPT ); Wed, 19 Apr 2017 09:13:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36554 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934315AbdDSNNi (ORCPT ); Wed, 19 Apr 2017 09:13:38 -0400 Date: Wed, 19 Apr 2017 15:13:22 +0200 From: Greg Kroah-Hartman To: "Maciej W. Rozycki" Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, James Hogan , Paul Burton , Ralf Baechle , linux-mips@linux-mips.org Subject: Re: [PATCH 4.4 27/32] MIPS: Force o32 fp64 support on 32bit MIPS64r6 kernels Message-ID: <20170419131322.GB32643@kroah.com> References: <20170410163839.055472822@linuxfoundation.org> <20170410163843.079809660@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 968 Lines: 25 On Sat, Apr 15, 2017 at 12:45:42AM +0100, Maciej W. Rozycki wrote: > On Mon, 10 Apr 2017, Greg Kroah-Hartman wrote: > > > Force o32 fp64 support in this case by also selecting > > MIPS_O32_FP64_SUPPORT from CPU_MIPS64_R6 if 32BIT. > [...] > > --- a/arch/mips/Kconfig > > +++ b/arch/mips/Kconfig > > @@ -1412,7 +1412,7 @@ config CPU_MIPS32_R6 > > select CPU_SUPPORTS_MSA > > select GENERIC_CSUM > > select HAVE_KVM > > - select MIPS_O32_FP64_SUPPORT > > + select MIPS_O32_FP64_SUPPORT if 32BIT > > help > > Choose this option to build a kernel for release 6 or later of the > > MIPS32 architecture. New MIPS processors, starting with the Warrior > > Has the patch been misapplied? Its description refers to CPU_MIPS64_R6, > however the hunk heading in the diff itself indicates CPU_MIPS32_R6. Ugh, you are right, I think I had to apply this one by hand, and got it really wrong. I'll go fix it up now, many thanks for pointing it out. greg k-h