Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763670AbdDSNZr (ORCPT ); Wed, 19 Apr 2017 09:25:47 -0400 Received: from gloria.sntech.de ([95.129.55.99]:45316 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763553AbdDSNZo (ORCPT ); Wed, 19 Apr 2017 09:25:44 -0400 From: Heiko Stuebner To: Olof Johansson Cc: Brian Norris , "devicetree@vger.kernel.org" , Doug Anderson , "linux-kernel@vger.kernel.org" , "open list:ARM/Rockchip SoC..." , Rob Herring , Chris Zhong , Stephen Barber , "linux-arm-kernel@lists.infradead.org" , Caesar Wang Subject: Re: [PATCH v2 1/6] arm64: dts: Add symlinks for cros-ec-keyboard and cros-ec-sbs Date: Wed, 19 Apr 2017 15:25:36 +0200 Message-ID: <2579212.374vCSe9xi@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: References: <20170210010521.78872-1-briannorris@chromium.org> <1529949.5djtX72aeJ@phil> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2108 Lines: 52 Am Mittwoch, 19. April 2017, 21:54:09 CEST schrieb Olof Johansson: > Hi, > > On Tue, Feb 28, 2017 at 3:20 AM, Heiko Stuebner wrote: > > Hi Olof, > > > > Am Dienstag, 21. Februar 2017, 15:47:31 CET schrieb Olof Johansson: > >> On Thu, Feb 9, 2017 at 5:05 PM, Brian Norris wrote: > >> > From: Douglas Anderson > >> > > >> > We'd like to be able to use the cros-ec-keyboard.dtsi and > >> > cros-ec-sbs.dtsi snippets for arm64 devices. Currently those files live > >> > in the arm/boot/dts directory. > >> > > >> > Let's follow the convention set by commit 8ee57b8182c4 ("ARM64: dts: > >> > vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm") and use > >> > a symlink. Note that in this case we put the files in a new > >> > "include/common" directory since these snippets may need to be > >> > referenced by dts files in many different subdirectories. > >> > >> I'd rather have something like this: > >> > >> https://marc.info/?m=147547436324674&w=2 > >> > >> Instead of having everybody move things over. I.e. make it easy to > >> refer to the arm version from arm64 instead of creating a "common" > >> layer inbetween. > > > > just so it gets noticed, I've done and tested [0], which hopefully should > > implement your suggestions above. > > > > If that looks ok, how do you want that picked up? Should I just include > > them in my regular rockchip branches or do you to pick them into some > > immutable branch, if other surprise-users turn up in time for 4.12? > > Sigh. I completely dropped the ball on this, and I didn't see it > included in any of your pull requests for 4.12 since I never actually > acked that approach. > > I've applied the patches onto a dt/include-paths stable branch, but > we're late for merging dependent code on top of it for 4.12. Didn't you merge the patches into a branch already and the rk3399-gru support on top of it? Aka https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/log/?h=shared/dt-symlinks Which one of my previous pull requests was already based on. Heiko