Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935494AbdDSOn7 (ORCPT ); Wed, 19 Apr 2017 10:43:59 -0400 Received: from mail.kernel.org ([198.145.29.136]:55780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934916AbdDSOns (ORCPT ); Wed, 19 Apr 2017 10:43:48 -0400 Date: Wed, 19 Apr 2017 23:43:38 +0900 From: Masami Hiramatsu To: "Naveen N. Rao" Cc: Michael Ellerman , Ingo Molnar , Ananth N Mavinakayanahalli , Masami Hiramatsu , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 7/7] powerpc: kprobes: remove duplicate saving of msr Message-Id: <20170419234338.24997b39e18506f07e4897bf@kernel.org> In-Reply-To: References: X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 37 On Wed, 19 Apr 2017 18:21:06 +0530 "Naveen N. Rao" wrote: > set_current_kprobe() already saves regs->msr into kprobe_saved_msr. Remove > the redundant save. > Looks good to me. Reviewed-by: Masami Hiramatsu Thank you, > Signed-off-by: Naveen N. Rao > --- > arch/powerpc/kernel/kprobes.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c > index 067e9863bfdf..5c0a1ffcbcf9 100644 > --- a/arch/powerpc/kernel/kprobes.c > +++ b/arch/powerpc/kernel/kprobes.c > @@ -272,7 +272,6 @@ int __kprobes kprobe_handler(struct pt_regs *regs) > */ > save_previous_kprobe(kcb); > set_current_kprobe(p, regs, kcb); > - kcb->kprobe_saved_msr = regs->msr; > kprobes_inc_nmissed_count(p); > prepare_singlestep(p, regs); > kcb->kprobe_status = KPROBE_REENTER; > -- > 2.12.1 > -- Masami Hiramatsu