Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764897AbdDSPCF (ORCPT ); Wed, 19 Apr 2017 11:02:05 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:38459 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936610AbdDSO56 (ORCPT ); Wed, 19 Apr 2017 10:57:58 -0400 Subject: Re: [PATCH] virtio_scsi: Always try to read VPD pages To: Stefan Hajnoczi , David Gibson References: <20170413021300.25023-1-david@gibson.dropbear.id.au> <20170413133909.GC13387@stefanha-x1.localdomain> Cc: famz@redhat.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: Date: Wed, 19 Apr 2017 16:57:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170413133909.GC13387@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 22 On 13/04/2017 15:39, Stefan Hajnoczi wrote: > On Thu, Apr 13, 2017 at 12:13:00PM +1000, David Gibson wrote: >> @@ -705,6 +706,28 @@ static int virtscsi_device_reset(struct scsi_cmnd *sc) >> return virtscsi_tmf(vscsi, cmd); >> } >> >> +static int virtscsi_device_alloc(struct scsi_device *sdevice) >> +{ >> + /* >> + * Passed through SCSI targets (e.g. with qemu's 'scsi-block') >> + * may have transfer limits which come from the host SCSI >> + * controller something on the host side other than the target > > s/controller something/controller or something/ ? Acked-by: Paolo Bonzini with this change. Paolo