Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765982AbdDSPdd convert rfc822-to-8bit (ORCPT ); Wed, 19 Apr 2017 11:33:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59916 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765892AbdDSPdO (ORCPT ); Wed, 19 Apr 2017 11:33:14 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8E122C059728 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8E122C059728 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <149141141298.29162.5612793122429261720.stgit@warthog.procyon.org.uk> <149141145858.29162.13072730133817038218.stgit@warthog.procyon.org.uk> To: Thomas Gleixner Cc: dhowells@redhat.com, LKML , gnomes@lxorguk.ukuu.org.uk, gregkh@linuxfoundation.org, Daniel Lezcano , linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, Jens Rottmann , Andres Salomon Subject: Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/ MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <25652.1492615985.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Wed, 19 Apr 2017 16:33:05 +0100 Message-ID: <25653.1492615985@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 19 Apr 2017 15:33:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 34 Hi Thomas, Thomas Gleixner wrote: > > --- a/drivers/clocksource/cs5535-clockevt.c > > +++ b/drivers/clocksource/cs5535-clockevt.c > > @@ -22,7 +22,7 @@ > > #define DRV_NAME "cs5535-clockevt" > > > > static int timer_irq; > > -module_param_named(irq, timer_irq, int, 0644); > > +module_param_hw_named(irq, timer_irq, int, irq, 0644); > > MODULE_PARM_DESC(irq, "Which IRQ to use for the clock source MFGPT ticks."); > > I'm not sure about this. AFAIR the parameter is required to work on > anything else than some arbitrary hardware which has it mapped to 0. > > Cc'ed people who might know. Given what Jens said: Parameter defaults to 0, which means: 1. autodetect (=keep IRQ BIOS has set up) 2. if that fails use CONFIG_CS5535_MFGPT_DEFAULT_IRQ (see drivers/misc/cs5535-mfgpt.c: cs5535_mfgpt_set_irq()) Autodetect works fine for our (ex-LiPPERT, now ADLINK) COTS boards: Linux auto-uses IRQ chosen in BIOS Setup. Wouldn't know about other companies, of course, but (2.) means parameter can be avoided via make menuconfig. are you willing to okay this? David