Message-ID: <1492623683.8661.63.camel@perches.com>
Subject: Re: [PATCH v3 tip/core/rcu 05/40] rcu: Semicolon inside RCU_TRACE()
 for rcu.h
From: Joe Perches <joe@perches.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com,
        akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
        josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
        rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
        fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com
Date: Wed, 19 Apr 2017 10:41:23 -0700
In-Reply-To: <1492621117-13939-5-git-send-email-paulmck@linux.vnet.ibm.com>
References: <20170419165805.GB10874@linux.vnet.ibm.com>
         <1492621117-13939-5-git-send-email-paulmck@linux.vnet.ibm.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 486
Lines: 9

On Wed, 2017-04-19 at 09:58 -0700, Paul E. McKenney wrote:
> The current use of "RCU_TRACE(statement);" can cause odd bugs, especially
> where "statement" is a local-variable declaration, as it can leave a
> misplaced ";" in the source code.  This commit therefore converts these
> to "RCU_TRACE(statement;)", which avoids the misplaced ";".

Perhaps instead the single RCU_TRACE macro should be split
into RCU_TRACE_DECLARE and RCU_TRACE, and then RCU_TRACE
should use do {} while (0)