Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968558AbdDSRlk (ORCPT ); Wed, 19 Apr 2017 13:41:40 -0400 Received: from smtprelay0178.hostedemail.com ([216.40.44.178]:48234 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S968359AbdDSRlh (ORCPT ); Wed, 19 Apr 2017 13:41:37 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3870:3871:3872:4321:5007:6742:8531:8957:10004:10400:10848:11026:11232:11473:11658:11914:12296:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21433:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:5,LUA_SUMMARY:none X-HE-Tag: event56_63a2f1bc69033 X-Filterd-Recvd-Size: 1647 Message-ID: <1492623683.8661.63.camel@perches.com> Subject: Re: [PATCH v3 tip/core/rcu 05/40] rcu: Semicolon inside RCU_TRACE() for rcu.h From: Joe Perches To: "Paul E. McKenney" , linux-kernel@vger.kernel.org Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Date: Wed, 19 Apr 2017 10:41:23 -0700 In-Reply-To: <1492621117-13939-5-git-send-email-paulmck@linux.vnet.ibm.com> References: <20170419165805.GB10874@linux.vnet.ibm.com> <1492621117-13939-5-git-send-email-paulmck@linux.vnet.ibm.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 486 Lines: 9 On Wed, 2017-04-19 at 09:58 -0700, Paul E. McKenney wrote: > The current use of "RCU_TRACE(statement);" can cause odd bugs, especially > where "statement" is a local-variable declaration, as it can leave a > misplaced ";" in the source code. This commit therefore converts these > to "RCU_TRACE(statement;)", which avoids the misplaced ";". Perhaps instead the single RCU_TRACE macro should be split into RCU_TRACE_DECLARE and RCU_TRACE, and then RCU_TRACE should use do {} while (0)