Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030642AbdDSSNT (ORCPT ); Wed, 19 Apr 2017 14:13:19 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:56949 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968887AbdDSSNR (ORCPT ); Wed, 19 Apr 2017 14:13:17 -0400 From: Arnd Bergmann To: Lucas Stach , David Airlie Cc: Zhang Rui , Eduardo Valentin , linux-pm@vger.kernel.org, Sujith Thomas , Arnd Bergmann , "Rafael J. Wysocki" , Len Brown , Russell King , Christian Gmeiner , Darren Hart , Andy Shevchenko , Daniel Vetter , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org Subject: [PATCH] drm/etnaviv: add thermal dependency Date: Wed, 19 Apr 2017 20:11:16 +0200 Message-Id: <20170419181209.537907-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:LGqBExYSnhicBHRlsTAvBNJQahfqCYlLZYAYDxLEQ9vmw3A1ltD aij7wbFCtVCvVmNjyC84o/FwQWFuYZZWbSGLWbk8SGmk8deLFkc0s3oX8ADGjH+3n3wJfGV vmFtTG8HFdAZ0LnqthIEKhZM1WxVp+E2qq31ec+mWIV6kKYGO6LKKA98HDgS3kN9y+oWlSU MzAtnULANvrxGZF3qTD/w== X-UI-Out-Filterresults: notjunk:1;V01:K0:ife9pfDM6xU=:0D07fWOzo2HbtpiRVVOmqK bND8c3HrLbmB3QCl1naOt3CPQ3TG7ebbRvvvpqiFaVJ7fQRlC0rDDmu7XYizh6H3LVMMGVPsD SHS4piOFJhEtQ9OGQFm7SCBj4M7YchBb8ak/2QAWHc4lTUUwCmpMWqQU2MD2OWEWTF2TfrhNg IgK2yUA7bMh2Tm/hNoAUaBpbcr2ZrXasoampZLxS9TB/sw5WBkh3ck1ET1vNpFPFgoEhtf7Zv kUVCK2DjfL16gl19VwXZGKIPDvGwQTsLMkoSxaVvgVdWS2yauY9Y0qKM1zvNf5FzPEYF0Kwck 6TnEZPsuDUJ5uw5NVfKDG+nN+dYUq+kEe0bDyHSqTJxPytUo2W3nRtBbRjT5ONSPMGYdCVVoy lLLtGuzctGxgZKoyEtoOsloUT3NBEK11KyeWuPUY5VnMuiwAyxgzoZvygZ9gtCoUfsioS0AyP 3hp6MyfMBzWRybnzT+ZkObVkKCDgT4S/ywhqd4JUlS2XZ9XZGkzo5TEzL2Jnkb7XH/Sj6PAfl fOjYol1C7gSEuUiCQIZ1x/P0neokGNlx0SO/uYGC4sMj285GlDsy8npejCqEm9U6uyEx1JisS owl9eApSEzzaq9y7aSPZ/ai8KgJ95rCepOF7hT1DG2LiXtxkXiXHgL1Kz8WDR1EdVsN07hlJL PZA7jRCOPSmZDlA3X78Bb2neSnOIWcmFlbwM8TTwyG47DdqMCsEsTeUgEdJJmgtUBPHY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2733 Lines: 65 When CONFIG_THERMAL is enabled as a loadable module, and etnaviv is built-in, we get a link error: drivers/gpu/drm/etnaviv/etnaviv_gpu.o: In function `etnaviv_gpu_bind': etnaviv_gpu.c:(.text.etnaviv_gpu_bind+0x34): undefined reference to `thermal_of_cooling_device_register' etnaviv_gpu.c:(.text.etnaviv_gpu_bind+0xe0): undefined reference to `thermal_cooling_device_unregister' drivers/gpu/drm/etnaviv/etnaviv_gpu.o: In function `etnaviv_gpu_unbind': etnaviv_gpu.c:(.text.etnaviv_gpu_unbind+0xf0): undefined reference to `thermal_cooling_device_unregister' This adds a Kconfig dependency to prevent etnaviv from being built-in with CONFIG_THERMAL=m, while still allowing the valid configurations. Unfortunately, simply adding the dependency here breaks Kconfig through a dependency loop involving lots of symbols all the way until ACPI_VIDEO, which is the only video driver that explicitly selects 'THERMAL'. Turning this into a 'depends on' addresses the problem. For completeness, I'm also removing the redundant 'select THERMAL' from INTEL_MENLOW, so no other driver uses that statement. Fixes: bcdfb5e56dc5 ("drm/etnaviv: add etnaviv cooling device") Signed-off-by: Arnd Bergmann --- drivers/acpi/Kconfig | 2 +- drivers/gpu/drm/etnaviv/Kconfig | 1 + drivers/platform/x86/Kconfig | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 03cc4e74096b..252399efa8b3 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -184,7 +184,7 @@ config ACPI_VIDEO tristate "Video" depends on X86 && BACKLIGHT_CLASS_DEVICE depends on INPUT - select THERMAL + depends on THERMAL help This driver implements the ACPI Extensions For Display Adapters for integrated graphics devices on motherboard, as specified in diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig index 71cee4e9fefb..1d6c744e7924 100644 --- a/drivers/gpu/drm/etnaviv/Kconfig +++ b/drivers/gpu/drm/etnaviv/Kconfig @@ -3,6 +3,7 @@ config DRM_ETNAVIV tristate "ETNAVIV (DRM support for Vivante GPU IP cores)" depends on DRM depends on ARCH_MXC || ARCH_DOVE || (ARM && COMPILE_TEST) + depends on THERMAL || THERMAL=n depends on MMU select SHMEM select SYNC_FILE diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index e229ea317b9c..76ced87efde5 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -544,7 +544,6 @@ config SENSORS_HDAPS config INTEL_MENLOW tristate "Thermal Management driver for Intel menlow platform" depends on ACPI_THERMAL - select THERMAL ---help--- ACPI thermal management enhancement driver on Intel Menlow platform. -- 2.9.0