Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031050AbdDSTNb (ORCPT ); Wed, 19 Apr 2017 15:13:31 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:60859 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S969240AbdDSTN2 (ORCPT ); Wed, 19 Apr 2017 15:13:28 -0400 Subject: Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example To: Wolfram Sang References: <20170412172800.23035-1-javier@osg.samsung.com> <20170412172800.23035-6-javier@osg.samsung.com> <20170419185113.msqhjm7fzqfeyjlk@ninjato> Cc: linux-kernel@vger.kernel.org, Aaro Koskinen , devicetree@vger.kernel.org, Rob Herring , Tony Lindgren , Lee Jones , linux-i2c@vger.kernel.org, Mark Rutland From: Javier Martinez Canillas Message-ID: Date: Wed, 19 Apr 2017 15:13:19 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170419185113.msqhjm7fzqfeyjlk@ninjato> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1059 Lines: 39 Hello Wolfram, On 04/19/2017 02:51 PM, Wolfram Sang wrote: > On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote: >> The example contains a device node for a retu device, but >> its compatible string doesn't have a vendor prefix. >> >> While being there, drop the -mfd suffix since isn't correct. >> >> Signed-off-by: Javier Martinez Canillas >> Acked-by: Rob Herring >> Acked-by: Aaro Koskinen >> Acked-by: Tony Lindgren > > Wouldn't it be nice if we fix the driver also so it actually matches the > below compatible? I can't find such a change in linux-next. > [snip] >> >> - retu-mfd: retu@1 { >> - compatible = "retu-mfd"; >> + retu: retu@1 { >> + compatible = "nokia,retu"; >> reg = <0x1>; >> }; You mean having a "nokia,retu" entry in a OF table? That's done by patch 3/8 in this series: http://www.spinics.net/lists/devicetree/msg173145.html Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America