Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935420AbdDSTjm (ORCPT ); Wed, 19 Apr 2017 15:39:42 -0400 Received: from sauhun.de ([88.99.104.3]:44773 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935289AbdDSTjk (ORCPT ); Wed, 19 Apr 2017 15:39:40 -0400 Date: Wed, 19 Apr 2017 21:39:33 +0200 From: Wolfram Sang To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Aaro Koskinen , devicetree@vger.kernel.org, Rob Herring , Tony Lindgren , Lee Jones , Mark Rutland Subject: Re: [v5,1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Message-ID: <20170419193933.ocnhxdfojanp5324@ninjato> References: <20170412172800.23035-2-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7sey23xxqp5mnjvx" Content-Disposition: inline In-Reply-To: <20170412172800.23035-2-javier@osg.samsung.com> User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3708 Lines: 102 --7sey23xxqp5mnjvx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 12, 2017 at 02:27:52PM -0300, Javier Martinez Canillas wrote: > There are Device Tree source files defining a device node for the > retu/tahvo I2C chip, but there isn't a DT binding document for it. >=20 > Signed-off-by: Javier Martinez Canillas > Acked-by: Rob Herring > Acked-by: Aaro Koskinen > Acked-by: Tony Lindgren > Acked-by: Lee Jones > --- >=20 > Changes in v5: > - Add missing properties for interrupts to DT binding doc (Rob Herring). > - Add Rob Herring's Acked-by tag. > - Add Aaro Koskinen's Acked-by tag. > - Add Acked-by: Tony Lindgren 's Acked-by tag. > - Add Lee Jones 's Acked-by tag. >=20 > Changes in v4: > - Use "dt-bindings: mfd:" prefix in subject line (Rob Herring). > - Add information about what functions the device serve (Lee Jones). > - Avoid using MFD in Device Tree (Lee Jones). >=20 > Changes in v3: None > Changes in v2: None >=20 > Documentation/devicetree/bindings/mfd/retu.txt | 23 ++++++++++++++++++++= +++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/retu.txt >=20 > diff --git a/Documentation/devicetree/bindings/mfd/retu.txt b/Documentati= on/devicetree/bindings/mfd/retu.txt > new file mode 100644 > index 000000000000..e1ea3a36a038 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/retu.txt > @@ -0,0 +1,23 @@ > +* Device tree bindings for Nokia Retu and Tahvo multi-function device > + > +Retu and Tahvo are a multi-function devices found on Nokia Internet > +Tablets (770, N800 and N810). The Retu chip provides watchdog timer > +and power button control functionalities while Tahvo chip provides > +USB transceiver functionality. > + > +Required properties: > +- compatible: "nokia,retu" or "nokia,tahvo" > +- reg: Specifies the I2C slave address of the ASIC chip This should be "CBUS slave address". CBUS is a strange subset of I2C, yet I'd like the distinction because 0x1 is not a valid I2C address. > +- interrupts: The interrupt line the device is connected to > +- interrupt-parent: The parent interrupt controller > + > +Example: > + > +i2c0 { To make it super clear, we are talking CBUS here, it might make sense to add here: + compatible =3D "i2c-cbus-gpio"; + ... ? It could be argued that the above "i2c0" should be "cbus0" as well but that is a separate issue, I'd think. > + retu: retu@1 { > + compatible =3D "nokia,retu"; > + interrupt-parent =3D <&gpio4>; > + interrupts =3D <12 IRQ_TYPE_EDGE_RISING>; > + reg =3D <0x1>; > + }; > +}; --7sey23xxqp5mnjvx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlj3vPUACgkQFA3kzBSg KbYTdhAAoiQaQHJMlLp0mJADYOqK6kwSFkF9N7+OHaBEw41dDsmasQMwFFf+kI0h c0KFhN0jjh0YZtWgjMnEeBs+E2bP5VZ5AvOY9pTTK4qYOnaQ/N8fIFD0i/OwW9VP yGkfGZBlLcxIQKmJqY+VOwlnmnJpR3WP+V1RTZSwHWjz9+83L/AyKrg56jDrBhV3 dvpglg/TJjoP5vIxP43Osfmo2Ot9HDDmI7re1yvevFkVgwxhUjw+5RR79rNmF7Ly S6vio+xfGpkM61RlaCE3mebmoC/3nO6qNTtCrrJaE/P0wREijaISLqcwVngibTI0 sey2cJMw/QRTxXQZ8IbKza5uP56EDrUReMB58fNvpsFDnhkQeqpuG1/pfoc+Iz7P r0MBgSSgRBy1RNuaOBa68qiH8L7p8leT/rsw7vP4v/DmDdv9ijB6iTIm7oXOeOa8 N1gZjeH1XAdnJkVpPyhdjGpOiuXE8gDcwYkYFsj801V+5NDjpgcDnL0Ik9PJZash lsJQh0JSOgYsTBR9XAV3Dxww0+akDdXCtwCxLWYmJJWp/NL8N2uM/68TT+pjdNKV b/DfAgUpCyUA+30wPZpArECLIVIQeGVdWF3UTDSSX+x0bH2sYC/H9SxMY7NU7cbW ZT2qxeENtW68wqvFNKXCL8qgk2INthXPDwpYQSLvS43pHb7zEUE= =zl6M -----END PGP SIGNATURE----- --7sey23xxqp5mnjvx--