Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940079AbdDSWMS (ORCPT ); Wed, 19 Apr 2017 18:12:18 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:49075 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936481AbdDSWMP (ORCPT ); Wed, 19 Apr 2017 18:12:15 -0400 From: "Rafael J. Wysocki" To: Olof Johansson Cc: Viresh Kumar , arm@kernel.org, Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Viresh Kumar , Nishanth Menon , Stephen Boyd , Beno??t Cousson , Tony Lindgren , Rob Herring , Mark Rutland , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Maxime Ripard , Chen-Yu Tsai , Masahiro Yamada , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , Rob Herring , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH V3] PM / OPP: Use - instead of @ for DT entries Date: Thu, 20 Apr 2017 00:06:03 +0200 Message-ID: <3142028.bncGUUQ4qB@aspire.rjw.lan> User-Agent: KMail/4.14.10 (Linux/4.11.0-rc6+; KDE/4.14.9; x86_64; ; ) In-Reply-To: <20170419142215.GA12105@localhost> References: <734c5d5a66ef8a5505f368fc68a8ab9c02d710f9.1492492253.git.viresh.kumar@linaro.org> <20170419142215.GA12105@localhost> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1302 Lines: 34 On Wednesday, April 19, 2017 07:22:15 AM Olof Johansson wrote: > Hi Viresh, > > On Tue, Apr 18, 2017 at 10:44:50AM +0530, Viresh Kumar wrote: > > Compiling the DT file with W=1, DTC warns like follows: > > > > Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a > > unit name, but no reg property > > > > Fix this by replacing '@' with '-' as the OPP nodes will never have a > > "reg" property. > > > > Reported-by: Krzysztof Kozlowski > > Reported-by: Masahiro Yamada > > Suggested-by: Mark Rutland > > Signed-off-by: Viresh Kumar > > Acked-by: Maxime Ripard (sunxi) > > Reviewed-by: Chanwoo Choi > > Reviewed-by: Krzysztof Kozlowski > > Acked-by: Masahiro Yamada (uniphier) > > Acked-by: Rob Herring > > Acked-by: Tony Lindgren > > We've already turned down other patches that does this in a sweeping manner > like this, since they tend to be conflict prone with other DT changes. > > Please split per platform and merge with each maintainer. OK So I'm assuming that you guys will take care of this going forward. Thanks, Rafael